Am 31.01.2015 um 08:48 schrieb Ritesh Raj Sarraf: > This is a follow-up on the comments that were made on changes to open-iscsi. > > Please review attached debdiff, which should have all changes included.
Hi Ritesh, I think you made a mistake: you've now merged both changes (the initial ones that Michael Biebl objected to) and the new ones. The original changes (dh-systemd dep, service file, calling systemctl from init script, moving debhelper around in postinst, dh_systemd_* in rules) should go away, and only the new changes (init script LSB headers, systemd drop in, install drop-in in debian/rules) should be kept. The debdiff you've attached includes both changes at the same time, and while that probably still works, it doesn't remove the objections Michael had to the initial ones. The diff I sent you earlier this week was against the version currently in testing/unstable, not against the version you had in git. Christian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
