Subject: unblock: cryptsetup/2:1.6.6-5 Package: release.debian.org User: release.debian....@packages.debian.org Usertags: unblock Severity: normal
Hi again,
I just uploaded cryptsetup 2:1.6.6-5 to unstable, fixing one single
reported bug, but also another - unreported - much worse bug. The report is:
Bug#773456: [cryptsetup] invoke-rc.d not found on boot
The severity of this bug is *just* 'normal'. But while fixing the bug, I
discovered a far worse bug in the same line of code, which I'd really
like to have fixed in time for jessie. I'm going to explain:
*/ The recently (in last upload, 2:1.6.6-4) introduced grep regex on
outputof 'status cryptdisks-udev ...' is insufficient. On systems
that use an init system != upstart but have upstart-bin installed,
this grep regex can lead to infinitive loops in the boot process.
[If you want me to, I can open a separate bugreport with rc severity
regarding this problem.]
*/ Apart from that, the recently (in last upload, 2:1.6.6-4) introduced
check for an upstart environment is broken. This will result in ugly
error messages on every system with encrypted devices and separate
/usr partition. (#773456)
*/ The fix introduced in this upload is very unintrusive. It only
changes the (before broken) logic to detect an upstart environment
and additionally fixes the (before insufficient) grep regex to
detect a currently running cryptdisks-udev (upstart) init script.
The debdiff is attached and here's the full changelog for this upload:
cryptsetup (2:1.6.6-5) unstable; urgency=high
* debian/cryptdisks.functions: fix the precheck for ubuntu+upstart
before invoking 'status cryptdisks-udev'. (closes: #773456)
* debian/cryptdisks.functions: fix the insufficient grep regex for
detecting a running cryptdisks-udev (upstart) init script.
-- Jonas Meurer <m...@debian.org> Thu, 22 Jan 2015 21:22:08 +0100
unblock cryptsetup/2:1.6.6-5
Cheers,
jonas
-- System Information:
Debian Release: jessie/sid
APT prefers utopic-updates
APT policy: (500, 'utopic-updates'), (500, 'utopic-security'), (500,
'utopic')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-29-generic (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru cryptsetup-1.6.6/debian/changelog cryptsetup-1.6.6/debian/changelog
--- cryptsetup-1.6.6/debian/changelog 2014-12-17 14:28:42.000000000 +0100
+++ cryptsetup-1.6.6/debian/changelog 2015-01-22 21:49:31.000000000 +0100
@@ -1,3 +1,12 @@
+cryptsetup (2:1.6.6-5) unstable; urgency=high
+
+ * debian/cryptdisks.functions: fix the precheck for ubuntu+upstart
+ before invoking 'status cryptdisks-udev'. (closes: #773456)
+ * debian/cryptdisks.functions: fix the insufficient grep regex for
+ detecting a running cryptdisks-udev (upstart) init script.
+
+ -- Jonas Meurer <m...@debian.org> Thu, 22 Jan 2015 21:22:08 +0100
+
cryptsetup (2:1.6.6-4) unstable; urgency=medium
[ Simon McVittie ]
diff -Nru cryptsetup-1.6.6/debian/cryptdisks.functions
cryptsetup-1.6.6/debian/cryptdisks.functions
--- cryptsetup-1.6.6/debian/cryptdisks.functions 2014-12-08
22:58:47.000000000 +0100
+++ cryptsetup-1.6.6/debian/cryptdisks.functions 2015-01-22
21:20:13.000000000 +0100
@@ -750,7 +750,7 @@
# will just be a no-op, but we don't want to defer to the
# other job entirely because this is the fallback for fixing
# up any ordering-dependent decrypting.
- invoke-rc.d --quiet cryptdisks-udev status && while status
cryptdisks-udev DEVNAME="$dev_match" 2>&1 | grep -q 'start'; do
+ [ -x /sbin/status ] && while /sbin/status cryptdisks-udev
DEVNAME="$dev_match" 2>&1 | grep -q "\<start"; do
sleep 1
done
handle_crypttab_line_start "$dst" "$src" "$key" "$opts" <&3 ||
log_action_end_msg $?
signature.asc
Description: OpenPGP digital signature
