Package: flashrom
Version: 0.9.7+r1852-1
Tags: sid patch
Severity: important
Justification: FTBFS
User: debian-m...@lists.debian.org
Usertags: mips-patch
Packge flashrom FTBFS for mipsel with an error:
> cc -MMD -g -O2 -fstack-protector-strong -Wformat -Werror=format-security
> -Wall -D_FORTIFY_SOURCE=2 -D'CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID'
> -D'CONFIG_DEFAULT_PROGRAMMER_ARGS="''"' -D'CONFIG_INTERNAL=1'
> -D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1'
> -D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1'
> -D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1'
> -D'HAVE_FT232H=1' -D'CONFIG_DUMMY=1' -D'CONFIG_DRKAISER=1'
> -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1' -D'CONFIG_NICINTEL_EEPROM=1'
> -D'CONFIG_OGP_SPI=1' -D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_LINUX_SPI=1'
> -D'NEED_PCI=1' -D'HAVE_UTSNAME=1' -D'FLASHROM_VERSION="0.9.7-r1852"' -o
> internal.o -c internal.c
> internal.c: In function 'internal_init':
> internal.c:332:52: error: 'cb_vendor' undeclared (first use in this function)
> if (board_flash_enable(board_vendor, board_model, cb_vendor, cb_model)) {
> ^
> internal.c:332:52: note: each undeclared identifier is reported only once for
> each function it appears in
> internal.c:332:63: error: 'cb_model' undeclared (first use in this function)
> if (board_flash_enable(board_vendor, board_model, cb_vendor, cb_model)) {
> ^
> make[1]: *** [internal.o] Error 1
Patch that conatins needed changes is attached.
This chage is aviale upstream, along with other changes.
With this patch I was able to build flashrom for mipsel locally.
Could you please consider including these changes?
Here is commit that conatins my fix.
https://github.com/stefanct/flashrom/commit/138245ea51472211ec12e7b4d176591f3f18ce38
If needed, we could use all chages from this commit.
Best Regards,
Dejan
--- flashrom-0.9.7+r1852.orig/internal.c 2014-10-27 20:09:27.000000000 +0000
+++ flashrom-0.9.7+r1852/internal.c 2015-01-13 09:06:03.000000000 +0000
@@ -327,12 +327,12 @@
/* Probe unconditionally for ITE Super I/O chips. This enables LPC->SPI translation on IT87* and
* parallel writes on IT8705F. Also, this handles the manual chip select for Gigabyte's DualBIOS. */
init_superio_ite();
-#endif
if (board_flash_enable(board_vendor, board_model, cb_vendor, cb_model)) {
msg_perr("Aborting to be safe.\n");
return 1;
}
+#endif
#if defined(__i386__) || defined(__x86_64__) || defined (__mips)
register_par_master(&par_master_internal, internal_buses_supported);
