On Mon, 15 Dec 2014 01:32:00 +0000 Nick Daly <nick.m.d...@gmail.com> wrote:
> Hello Neil, apologies for the long delay on this. I've attached a > patch that solves this bug and two other bugs: > > 1. BuildBot Fixes: Attempts to build with a TTY device, and falls > back to headless mode if TTY device is unavailable. This change > allows BuildBot builds to complete. I don't see the patch for this in the BTS. As this is the original intent of the bug report, the patch needs to be in the bug report. > 2. Add customize-chroot support: Adds new "--customize-in-chroot" I don't want to be this prescriptive. customise can use chroot itself and there are perfectly valid reasons why the customise script needs to run outside the chroot - e.g. to dd the u-boot image into the space ahead of the first partition. There are also problems of *which* chroot? So, no on this one. > 3. Fail Faster: Treat IO errors as build failures because they imply > that other parts of the build (parts that will probably take much > longer) will also fail. I've ended up wasting hours this way, > because we got to the customize script, which took hours to fail. I've been testing customise scripts recently, set -e on the customise script is enough. From that paragraph I have no idea what IO errors you are experiencing or how the change helps. -- Neil Williams ============= http://www.linux.codehelp.co.uk/
pgpt3aZHk6iPw.pgp
Description: OpenPGP digital signature
