Control: tag -1 moreinfo

On Wed, Dec 17, 2014 at 02:31:00PM +0000, Barak A. Pearlmutter wrote:
> +vala-mode-el (0.1-2) unstable; urgency=medium
> +
> +  * Patch away `(lambda ... ,foo ...) ickiness (closes: #702714)

This is the bug fix, right?

> +  * Source option single-debian-patch for in-tree rather than quilt patch

Unless you have a really good reason for doing it this isn't suitable for
freeze.

> +  * Add support to use C# semantics when ECB and CEDIT are both installed

This sounds like a feature?

> diff -Nru vala-mode-el-0.1/debian/emacsen-compat 
> vala-mode-el-0.1/debian/emacsen-compat
> --- vala-mode-el-0.1/debian/emacsen-compat    1970-01-01 01:00:00.000000000 
> +0100
> +++ vala-mode-el-0.1/debian/emacsen-compat    2014-12-17 12:42:26.000000000 
> +0000
> @@ -0,0 +1 @@
> +0

This isn't mentioned in the changelog, unless I missed it. (Neither emacs
nor vala are in my strong set.)

> diff -Nru vala-mode-el-0.1/debian/patches/debian-changes 
> vala-mode-el-0.1/debian/patches/debian-changes
> --- vala-mode-el-0.1/debian/patches/debian-changes    1970-01-01 
> 01:00:00.000000000 +0100
> +++ vala-mode-el-0.1/debian/patches/debian-changes    2014-12-17 
> 14:23:05.000000000 +0000
> @@ -0,0 +1,105 @@
> +Description: <short summary of the patch>
> + TODO: Put a short summary on the line above and replace this paragraph
> + with a longer explanation of this change. Complete the meta-information
> + with other relevant fields (see below for details). To make it easier, the
> + information below has been extracted from the changelog. Adjust it or drop
> + it.
> + .
> + vala-mode-el (0.1-2) unstable; urgency=medium
> + .
> +   * Patch away `(lambda ... ,foo ...) ickiness (closes: #702714)
> +   * Source option single-debian-patch for in-tree rather than quilt patch
> +   * Bump debian standards version (no changes required)
> +   * Update upstream location
> +   * Fix grammar in comment in source code
> +   * Add support to use C# semantics when ECB and CEDIT are both installed
> +Author: Barak A. Pearlmutter <b...@debian.org>
> +Bug-Debian: https://bugs.debian.org/702714
> +
> +---
> +The information above should follow the Patch Tagging Guidelines, please
> +checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
> +are templates for supplementary fields that you might want to add:
> +
> +Origin: <vendor|upstream|other>, <url of original patch>
> +Bug: <url in upstream bugtracker>
> +Bug-Debian: https://bugs.debian.org/<bugnumber>
> +Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
> +Forwarded: <no|not-needed|url proving that it has been forwarded>
> +Reviewed-By: <name and email of someone who approved the patch>
> +Last-Update: <YYYY-MM-DD>

Lots of new cruft here. (Can one have new cruft? Hmm.)

> diff -Nru vala-mode-el-0.1/debian/patches/series 
> vala-mode-el-0.1/debian/patches/series
> --- vala-mode-el-0.1/debian/patches/series    1970-01-01 01:00:00.000000000 
> +0100
> +++ vala-mode-el-0.1/debian/patches/series    2014-12-17 14:23:05.000000000 
> +0000
> @@ -0,0 +1 @@
> +debian-changes

Let's not do this. 0.1-1 is already source format 3.0 (quilt), so proper
patches are easy.

-- 
Jonathan Wiltshire                                      j...@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

Attachment: signature.asc
Description: Digital signature

Reply via email to