Hi Markus, On Tue, Dec 02, 2014 at 04:47:58PM +0200, Markus Lehtonen wrote: > Hello, > > On Fri, 2014-11-28 at 14:55 +0100, Guido Günther wrote: > > On Fri, Nov 28, 2014 at 12:11:01PM +0200, Markus Lehtonen wrote: > > [..snip..] > > > If you're willing to wait for few days I could look into this and provide > > > a patchset with minimal pq-rpm implementation (i.e. all the new cmdline > > > options, even configurable branch names, removed). What I'd like to have > > > there are the unit tests. > > > > That would be awesome! I'd be great to have a second tool merged. > > The attached series implements an initial version of the pq-rpm tool. > The first four patches (0001-0004) are required to make the actual > pq-rpm tool to work correctly. The next four patches (0005-0008) are > requirements for the unit tests. The last patch finally implements > gbp-pq-rpm tool itself. > > This series (plus some additional features) is also available in > feature/pq-rpm branch in my Github repository: > git clone git://github.com/marquiz/git-buildpackage-rpm.git -b > feature/pq-rpm
I had a look at this branch an it looks great. I'd feel more comfortable if we'd had a unit test for dump_tree with recursive though (af39e32692ebedb4316b28851e10f737bf176105) - can you add that, I can pull in the rest then. Cheers, -- Guido -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
