Package: release.debian.org
User: release.debian....@packages.debian.org
Usertags: unblock
Severity: normal

Please unblock the python-flickrapi package to make it able to talk to
the Flickr web API (bug #769722).

To get the patched source building I had to add --prefix=/usr to the
rules file, and fixed a lintian warning about missing dependencies in
the process.

Here is the diff between version 1.2-3 already in testing and 1.2-3.1
in unstable.  In addition to these changes, the build changed a few
generated files in the source package:

--- python-flickrapi-1.2/debian/changelog
+++ python-flickrapi-1.2/debian/changelog
@@ -1,3 +1,14 @@
+python-flickrapi (1.2-3.1) unstable; urgency=low
+
+  * Non-maintainer upload to get module working again.
+  * Change API URLs from http to https to get them working with the
+    current Flickr API where SSL is required (Closes: #769722).
+  * Add missing ${misc:Depends} to dependency list.
+  * Add --prefix=/usr to setup run in rules file to make sure the
+    documentation end up in /usr/share/doc/, not /usr/local/share/doc/.
+
+ -- Petter Reinholdtsen <p...@debian.org>  Mon, 17 Nov 2014 21:48:46 +0100
+
 python-flickrapi (1.2-3) unstable; urgency=low
 
   * Improved package long description (closes: #531014)
diff -u python-flickrapi-1.2/debian/control python-flickrapi-1.2/debian/control
--- python-flickrapi-1.2/debian/control
+++ python-flickrapi-1.2/debian/control
@@ -13,7 +13,7 @@
 Package: python-flickrapi
 Architecture: all
 XB-Python-Version: ${python:Versions}
-Depends: ${python:Depends},
+Depends: ${python:Depends}, ${misc:Depends}
 Description: Flickr API wrapper for Python
  Python-flickrapi is a complete and easy to use Python
  module for interfacing with the Flickr API (see
diff -u python-flickrapi-1.2/debian/rules python-flickrapi-1.2/debian/rules
--- python-flickrapi-1.2/debian/rules
+++ python-flickrapi-1.2/debian/rules
@@ -21,7 +21,7 @@
        dh_installdirs
        set -e; \
        for python in $(PYVERS); do \
-           $$python setup.py install --root=$(d);\
+           $$python setup.py install --root=$(d) --prefix=/usr ;\
        done
 
 binary-indep: build install
diff -u python-flickrapi-1.2/debian/changelog 
python-flickrapi-1.2/debian/changelog
--- python-flickrapi-1.2.orig/flickrapi/__init__.py
+++ python-flickrapi-1.2/flickrapi/__init__.py
@@ -386,7 +386,7 @@
         if self.cache and self.cache.get(post_data):
             return self.cache.get(post_data)
 
-        url = "http://"; + FlickrAPI.flickr_host + FlickrAPI.flickr_rest_form
+        url = "https://"; + FlickrAPI.flickr_host + FlickrAPI.flickr_rest_form
         flicksocket = urllib.urlopen(url, post_data)
         reply = flicksocket.read()
         flicksocket.close()
@@ -440,7 +440,7 @@
                     "frob": frob,
                     "perms": perms})
 
-        return "http://%s%s?%s"; % (FlickrAPI.flickr_host, \
+        return "https://%s%s?%s"; % (FlickrAPI.flickr_host, \
             FlickrAPI.flickr_auth_form, encoded)
 
     def web_login_url(self, perms):
@@ -454,7 +454,7 @@
                     "api_key": self.api_key,
                     "perms": perms})
 
-        return "http://%s%s?%s"; % (FlickrAPI.flickr_host, \
+        return "https://%s%s?%s"; % (FlickrAPI.flickr_host, \
             FlickrAPI.flickr_auth_form, encoded)
 
     def __extract_upload_response_format(self, kwargs):
@@ -578,7 +578,7 @@
         
         if self.secret:
             kwargs["api_sig"] = self.sign(kwargs)
-        url = "http://%s%s"; % (FlickrAPI.flickr_host, form_url)
+        url = "https://%s%s"; % (FlickrAPI.flickr_host, form_url)
 
         # construct POST data
         body = Multipart()

-- 
Happy hacking
Petter Reinholdtsen


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to