On 16/11/14 17:09, Evgeni Golov wrote:
On 11/16/2014 06:00 PM, Evgeni Golov wrote:
Right, how about this:

The correct patch would be:
diff --git a/debian/README.Debian b/debian/README.Debian
index 97ea7cf..f914834 100644
--- a/debian/README.Debian
+++ b/debian/README.Debian
@@ -1,6 +1,16 @@
 hdapsd for Debian
 -----------------

+disable hdapsd
+==============
+
+hdapsd can be disabled on boot, if you want to start it manually.
+
+To disable hdapsd under systemd, use “systemctl disable hdapsd.service”.
+For inits using the init.d scripts, adjust /etc/default/hdapsd to have
+  START=no
+in it.
+
 hdapsd with kernels <= 2.6.27
 =============================

diff --git a/debian/rules b/debian/rules
index fdbeae1..a7c6726 100755
--- a/debian/rules
+++ b/debian/rules
@@ -14,10 +14,3 @@ override_dh_auto_install:
 override_dh_auto_clean:
        dh_auto_clean
        rm -f $(CURDIR)/misc/*.service
-
-override_dh_systemd_enable:
-       # Do not enable the file by default on purpose.
-       # The user should enable it only after making sure the
configuration is
-       # appropriate for his/her computer.
-       # This corresponds to START=no in /etc/default/hdapsd
-       dh_systemd_enable --no-enable

That would also enable hdapsd after installation on systemd, which is
what you actually want.

That looks reasonable. I had found the START=yes line, which didn't help me
on systemd. I can't think of any reason why you would install the package
and want it to not run. The default configuration looks as if it should work
for the majority of cases and I assume it's not going to do any harm if it's
incorrectly configured or if the hardware doesn't exist. It's not as if it
is opening network ports with security implications.

I've never
used systemd before and I'm not enjoying it. I'm not convinced the Debian
packaging is ready yet for a stable release.

systemd packaging or hdapsd packaging?

systemd. I am surprised at how much sysvinit configuration is apparently not implemented in systemd. And I'm struggling with the lack of configuration files with only a binary interface through systemctl.

Roger


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to