Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Please unblock package libpoe-component-client-mpd-perl:
2.000-2 fixes RC bug #768712, a test failure caused by a behaviour
change in mpd:
libpoe-component-client-mpd-perl (2.000-2) unstable; urgency=medium
* Add patch to make tests work with mpd >= 0.19.
One tests checks for the accumulated playtime of the audio samples.
Test::Corpus::Audio::MPD contains 5 tracks just over 1.8 seconds each.
mpd < 0.19 rounded each track up to 2 seconds then added the lengths in
seconds to get 10s, but mpd >= 0.19 adds up the lengths in ms and then
rounds it down to 9s. Change this test to look for >= 9 and <= 10 seconds.
Thanks to Simon McVittie for the patch. (Closes: #768712)
-- gregor herrmann <gre...@debian.org> Wed, 12 Nov 2014 21:22:45 +0100
Full debdiff attached.
unblock libpoe-component-client-mpd-perl/2.000-2
Cheers,
gregor
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJUY8QGXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREMUUxMzE2RTkzQTc2MEE4MTA0RDg1RkFC
QjNBNjgwMTg2NDlBQTA2AAoJELs6aAGGSaoGFekQAMBnircscsgo/1F67Jm2oL38
jHTSV5ouY53umzQWGkpAk1OOLnAQmMqL7arDd0MUlP1X+FftZTZVOZl/zgFy3wOE
qyuUa3qVIULI+4GX5u9rN8Bhrw/bHYb4c3/769OdKlIkh9WpVFoqkri6h6LS2OjT
mNjFz9U7Ew22vZCMisjd1GZfw+elxegeZc1UYf792TWN/LmvpChVR/oBQXLFNEeJ
9Tsekp3rye4dLHgJLjIiLQHDCfF9l60b6Rhpq6yhvtX/DH5S8A69G9iqQQNDWz+y
eSHbshq2A5ebNnh+SH/G4/npdKS2NwaBZ74j92vN9l3PVjGk1vPbDc4p4/j6MmHN
Qox0LG7WFGOo+TOppxlv4sWewF8Ddf9xn3jXR1l9tqXHq+U21MCYOZlS4rvxtV4w
z4zLth2f+IMnUVOecbz3tIogWS/NvyxXtmSWUWRbZZnHGZC2n2bEuCfXAup++WtU
UsOrJhf2U83VORluQ/qyhgAF/OvOhtXrtS0nnm5TTHwG2DZ571aTxH8jYIga6yci
pyQ8QL7c+kGYHF2SU2qK2pZm95/sH+9XmM3i+p22NWqkw7QEnJsMVSPSiTG6mxA+
EzRO9TVAXon1rPFMURdY33ibMd9mwhPd5GqONsdKOlw9/+UtwCG8eRt7FNpeGTZV
/dPfQ9G7YxLZBGY2deJF
=ct61
-----END PGP SIGNATURE-----
diff -Nru libpoe-component-client-mpd-perl-2.000/debian/changelog libpoe-component-client-mpd-perl-2.000/debian/changelog
--- libpoe-component-client-mpd-perl-2.000/debian/changelog 2014-06-12 11:09:06.000000000 +0200
+++ libpoe-component-client-mpd-perl-2.000/debian/changelog 2014-11-12 21:23:41.000000000 +0100
@@ -1,3 +1,17 @@
+libpoe-component-client-mpd-perl (2.000-2) unstable; urgency=medium
+
+ * Add patch to make tests work with mpd >= 0.19.
+
+ One tests checks for the accumulated playtime of the audio samples.
+ Test::Corpus::Audio::MPD contains 5 tracks just over 1.8 seconds each.
+ mpd < 0.19 rounded each track up to 2 seconds then added the lengths in
+ seconds to get 10s, but mpd >= 0.19 adds up the lengths in ms and then
+ rounds it down to 9s. Change this test to look for >= 9 and <= 10 seconds.
+
+ Thanks to Simon McVittie for the patch. (Closes: #768712)
+
+ -- gregor herrmann <gre...@debian.org> Wed, 12 Nov 2014 21:22:45 +0100
+
libpoe-component-client-mpd-perl (2.000-1) unstable; urgency=low
[ gregor herrmann ]
diff -Nru libpoe-component-client-mpd-perl-2.000/debian/patches/mpd-0.19.patch libpoe-component-client-mpd-perl-2.000/debian/patches/mpd-0.19.patch
--- libpoe-component-client-mpd-perl-2.000/debian/patches/mpd-0.19.patch 1970-01-01 01:00:00.000000000 +0100
+++ libpoe-component-client-mpd-perl-2.000/debian/patches/mpd-0.19.patch 2014-11-12 21:23:41.000000000 +0100
@@ -0,0 +1,34 @@
+Description: Adjust test to mpd >= 0.19
+ Test::Corpus::Audio::MPD contains 5 tracks just over 1.8 seconds each.
+ mpd < 0.19 rounded each track up to 2 seconds then added the lengths
+ in seconds to get 10s, but mpd >= 0.19 adds up the lengths in ms and then
+ rounds it down to 9s.
+Origin: vendor
+Bug-Debian: https://bugs.debian.org/768712
+Author: Simon McVittie <s...@debian.org>
+Reviewed-by: gregor herrmann <gre...@debian.org>
+Last-Update: 2014-11-12
+Forwarded: https://rt.cpan.org/Ticket/Display.html?id=100301
+Bug: https://rt.cpan.org/Ticket/Display.html?id=100301
+
+--- a/t/42-cmds-info.t
++++ b/t/42-cmds-info.t
+@@ -20,7 +20,7 @@
+ # are we able to test module?
+ eval 'use Test::Corpus::Audio::MPD';
+ plan skip_all => $@ if $@ =~ s/\n+Compilation failed.*//s;
+-plan tests => 29;
++plan tests => 30;
+
+ # launch fake mpd
+ POE::Component::Client::MPD->spawn;
+@@ -70,7 +70,8 @@
+ is($stats->albums, 1, 'one album in the database');
+ is($stats->songs, 5, '5 songs in the database');
+ is($stats->playtime, 0, 'already played 0 seconds');
+- is($stats->db_playtime, 10, '10 seconds worth of music in the db');
++ cmp_ok($stats->db_playtime, '>=', 9, '>= 9 seconds worth of music in the db');
++ cmp_ok($stats->db_playtime, '<=', 10, '<= 10 seconds worth of music in the db');
+ isnt($stats->uptime, undef, 'uptime is defined');
+ isnt($stats->db_update, 0, 'database has been updated');
+ }
diff -Nru libpoe-component-client-mpd-perl-2.000/debian/patches/series libpoe-component-client-mpd-perl-2.000/debian/patches/series
--- libpoe-component-client-mpd-perl-2.000/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ libpoe-component-client-mpd-perl-2.000/debian/patches/series 2014-11-12 21:23:41.000000000 +0100
@@ -0,0 +1 @@
+mpd-0.19.patch
