On So, 2014-11-02 at 00:41 +0100, Stéphane Aulery wrote: > Hello Gerd, > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=429141 > > I asked the opinion of Moritz on this bug. I'm not convinced that this > work worthwhile. What do you say please?
Checking each and every malloc is pretty pointless. There are a few places where fbi allocates possibly pretty big chunks of memory, for example for a new image. For those it might make sense to check. First there are fewer places, and second fbi can actually do something about it (for example try reduce cache size and free cached images). Might still be it doesn't change much in practice though. Thanks to memory overcommit linux is doing by default large mallocs will just reserve address space which is initially not backed by memory. So malloc can succeed even if the memory needed to actually back it isn't available. cheers, Gerd -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
