package: munin-plugins-extra
severity: minor
x-debbugs-cc: Steve Schnepp <steve.schn...@gmail.com>
version: 2.0.24-1
# also in 2.1.9

Hi,

on jenkins.debian.net I'd like to use the iostat_ios plugin but it's 
autoconfiguration "helpfully" decides to only monitor /dev/dmX devices on that 
host, while the interesting ones are /dev/vda and /dev/vdb.

root@jenkins:~# cat /proc/diskstats 
 254       0 vda 14440293 403905 1050453130 201710680 18536760 288707751 
2458658344 1392859460 5 65066816 1594664896
 254       1 vda1 13872730 147690 1043862906 197725352 18218312 283660992 
2415226528 1349161840 5 64389092 1546875300
 254       2 vda2 567038 256215 6586024 3978816 318448 5046759 43431816 
43697620 0 3407168 47759440
 254      16 vdb 1923157 20106049 176269082 23264064 5341016 388173977 
3148375760 477443868 0 66456272 501315348
   7       0 loop0 0 0 0 0 0 0 0 0 0 0 0
   7       1 loop1 0 0 0 0 0 0 0 0 0 0 0
   7       2 loop2 0 0 0 0 0 0 0 0 0 0 0
   7       3 loop3 0 0 0 0 0 0 0 0 0 0 0
   7       4 loop4 0 0 0 0 0 0 0 0 0 0 0
   7       5 loop5 0 0 0 0 0 0 0 0 0 0 0
   7       6 loop6 0 0 0 0 0 0 0 0 0 0 0
   7       7 loop7 0 0 0 0 0 0 0 0 0 0 0
 253       1 dm-1 309693 0 2477544 4316532 1989959 0 15919672 1956711660 0 
489964 1961210648
root@jenkins:~# 

I've hacked the plugin to make it work for that host by these changes (compared 
to 2.0.24 in /usr):

matrix:~/Projects/jenkins.debian.net/jenkins.debian.net$ diff 
etc/munin/plugins/iostat_ios /usr/share/munin/plugins/iostat_ios 
104c104
<         return 0 if ($major == 253); # LVM2 devices
---
>         return 0 if ($major == 254); # LVM2 devices
108c108
<         return 0 if ($tmpnam =~ /^\s*(?:sd|hd|vd)[a-z]\d+\s*$/);
---
>         return 0 if ($tmpnam =~ /^\s*(?:sd|hd)[a-z]\d+\s*$/);
124c124

The second change is being tracked as "#767017 iostat_ios plugin should support 
/dev/vdX".

The autoconfiguration of the plugin is a nice idea, but I think there are 
several usecases where it's smart logic is not so smart at all. This is one.


cheers,
        Holger

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to