On Thu, 2014-10-23 at 22:31 -0400, Harlan Lieberman-Berg wrote: > Glad to help! I'll take a look at this tonight, and I'll send both of > you two emails separately, CCed to the particular bugs.
Hello! Thanks for packaging libu2f-host for Debian! Sorry for the delay in the review; I had family visiting that took up more time than I thought it would. Took a look over the package, and there are a couple things that need fixing - some as upstream, and some as packaging for Debian. 1. There are several generated files included as part of the tarball that really should be removed, if possible. The m4 stuff has several examples of generated files in it - aclocal.m4, several Makefile.in's, much of the content in ./build-aux (depcomp, config.sub, ar-lib, test-driver, among others). If you could go through and remove these generated files, it's preferable. As much as possible, the upstream source should be kept clean and files regenerated as needed. (See https://wiki.debian.org/UpstreamGuide#Generated_files for more information). 2. In a similar vein, the documentation u2f-host.pdf should be regenerated at build time, rather than the pdf be included. If it can be removed from the upstream tarball, that would be preferable, but if not, it should be regenerated at build-time in the debian/rules. 3. The watchfile is currently not working because the link it is scraping is returning a 500 error. Other than that, the package looks pretty good! Let me know when you've made the above fixes, and I'll take another look through it - quicker, next time, I hope! Sincerely, -- Harlan Lieberman-Berg ~hlieberman -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
