In article <[EMAIL PROTECTED]> you wrote:
> Package: linux-2.6
> Severity: minor
> 
>  I'm booting using the "quiet" kernel option.  During the synthesizing
> of the initial hotplug events, I see the following messages show up:
> 
>    shpchp: shpc_init : shpc_cap_offset == 0
>    shpchp: shpc_init : shpc_cap_offset == 0
> 
>  I don't know what this means, but I doubt it is important enough to
> break the silence I requested using "quiet".  I don't even have a
> machine capable of PCI hotplugging.
> 
>  If the issue is important enough to bother me about after all, it
> should say what the problem is in plain English, so I can actually do
> something about it.

I've CCed the upstream maintainer, to bring this minor issue
to his attention. 

Greg, I see in the code that message is logged using err(),
perhaps dbg() would be more appropriate. Trivial patch for reference:

    PCI hotplug: Be slightly quieter about shpc_cap_offset == 0
    
    It seems that the following message, logged as err() can show
    up during normal boots.
    
    See: http://bugs.debian.org/341761
    
    Signed-Off-By: Horms <[EMAIL PROTECTED]>

diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
index 9987a6f..69f0e5d 100644
--- a/drivers/pci/hotplug/shpchp_hpc.c
+++ b/drivers/pci/hotplug/shpchp_hpc.c
@@ -1351,7 +1351,7 @@ int shpc_init(struct controller * ctrl, 
                shpc_base_offset = 0;  /* amd shpc driver doesn't use this; 
assume 0 */
        } else {
                if ((shpc_cap_offset = pci_find_capability(pdev, 
PCI_CAP_ID_SHPC)) == 0) {
-                       err("%s : shpc_cap_offset == 0\n", __FUNCTION__);
+                       dbg("%s : shpc_cap_offset == 0\n", __FUNCTION__);
                        goto abort_free_ctlr;
                }
                dbg("%s: shpc_cap_offset = %x\n", __FUNCTION__, 
shpc_cap_offset);       


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to