-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sun, 4 Dec 2005 11:22:09 +1030 Ron <[EMAIL PROTECTED]> wrote:
> Hi, > > On Sat, Dec 03, 2005 at 01:29:27PM +0100, Jonas Smedegaard wrote: > > Package: cpad-kernel-source > > Severity: important > > Tags: patch > > > > The following command should work: > > > > KSRC=/usr/src/linux-headers-2.6.14-2-386 KPKG_DEST_DIR="\ > > $(CURDIR)/.." KDREV="0.99.jones1" fakeroot debian/rules > > kdist_configure kdist_image > > I'm not sure if that is strictly true. The following should work: > > > fakeroot debian/rules kdist_configure kdist_image > > KSRC=/usr/src/linux-headers-2.6.14-2-386 KPKG_DEST_DIR="\ > > $(CURDIR)/.." KDREV="0.99.jones1" > > As should the line you gave if the '-e' option was also passed to > make. > > But I have some question as to whether what you first tried should > work by default or not. My best authority at this stage, runs > something like: > > 6.9 Variables from the Environment > ================================== > > Variables in `make' can come from the environment in which `make' is > run. Every environment variable that `make' sees when it starts up > is transformed into a `make' variable with the same name and value. > But an explicit assignment in the makefile, or with a command > argument, overrides the environment. (If the `-e' flag is specified, > then values from the environment override assignments in the > makefile. *Note Summary of Options: Options Summary. But this is > not recommended practice.) > > Which seems to indicate this is intentional and preferred behaviour > that we should not mess with lightly (and hence there is no bug > here at all) -- but I'll take arguments as to why this variable > is special and should be taken from the environment by default. > Along with a list of what others should receive similar red-carpet > treatment if any should. Thanks for the clarification. Indeed it works when passing the variables to make environment instead of only to the outside one. The bigger aim is to allow building with standard Debian package building tools rather than being forced to use make directly due to specific arguments required passed. But you are right that then the variables needing extra care should be explicitly declared. I believe the defacto-standard of module building comes from the module building guideline written by Manoj as part of kernel-package, but no real policy exist about this, I believe. The variables seeming to require extra care is KSRC, KVERS, KDREV and KPKG_DEST_DIR. Read more here: http://wiki.debian.org/KernelModulesPackaging You use variables KSRC and KDREV identical to those mentioned above, and seem to take extra care about KDREV being passed from the build environment, but not KSRC. Why? - Jonas - -- * Jonas Smedegaard - idealist og Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ - Enden er nær: http://www.shibumi.org/eoti.htm -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFDkv7Hn7DbMsAkQLgRAmNrAJ4gvGbUZzg+f+iHB4NhOCwLTo+y8ACgoBuZ mvtCd7QwzDrt9x76Nhq2RVQ= =J3PT -----END PGP SIGNATURE-----
