Control: tags -1 pending Hi,
> This patch adds initial support for ppc64el, fixing a lot of test failures
> that
> is happening on buildd right now.
>
[...]
Many thanks for this patch. It seems upstream has some of these changes in SVN
already and I'll try to merge the missing parts from your patch, but there is
one bit that surprised me a bit in your proposal:
[...]
@@ -348,10 +352,13 @@ void configt::ansi_ct::set_arch_spec_pow
{
case MODE_GCC_C:
case MODE_GCC_CPP:
- defines.push_back("__powerpc");
- defines.push_back("__powerpc__");
- defines.push_back("__POWERPC__");
- defines.push_back("__ppc__");
+ if(subarch=="powerpc")
+ {
+ defines.push_back("__powerpc");
+ defines.push_back("__powerpc__");
+ defines.push_back("__POWERPC__");
+ defines.push_back("__ppc__");
+ }
if(os==OS_MACOS)
defines.push_back("__BIG_ENDIAN__");
break;
[...]
I think that subarch==ppc64le (and subarch==ppc64) actually need both the
defines for powerpc as well as those for 64 bits!?
Best,
Michael
pgpiyXSfBNOjq.pgp
Description: PGP signature
