* Martin Michlmayr <[EMAIL PROTECTED]> [2005-12-03 21:42]:
> When jack can find no DYEAR or YEAR information in jack.freedb, it
> will happily write DATE=0 to the meta information, which of course is
> completely bogus. This problem was introduced in patch
> 84_dyear_dgenre.patch
Sorry for breaking this. Below is a patch (to be applied after
84_dyear_dgenre.patch).
> 7789:[EMAIL PROTECTED]: ..eklamation/wir_sind_helden] jack -R -t 1
> This is jack 3.1.1 (C)2004 Arne Zellentin <[EMAIL PROTECTED]>
> debug: [u'Wir Sind Helden', u'Die Reklamation', 0]
> Tagging.
> Done with "Wir Sind Helden - Die Reklamation".
> Year: 0
> Avg. bitrate: 153kbit
diff -urN jack-3.1.1~/jack_freedb.py jack-3.1.1/jack_freedb.py
--- jack-3.1.1~/jack_freedb.py 2005-12-03 21:44:52.000000000 +0000
+++ jack-3.1.1/jack_freedb.py 2005-12-03 21:46:49.000000000 +0000
@@ -431,7 +431,7 @@
dtitle = "(unknown artist)/" + dtitle
names = [string.split(dtitle,"/",1)]
- year = 0
+ year = -1
if freedb.has_key('DYEAR'):
try:
year = int(freedb['DYEAR'])
@@ -451,7 +451,7 @@
warning("DGENRE should be a string, not an integer.")
if genre != -1:
names[0].extend([year, genre])
- else:
+ elif year != -1:
names[0].extend([year])
if freedb.has_key('EXTD') and not(freedb.has_key('DYEAR') or
freedb.has_key('DGENRE')):
extra_tag_pos = string.find(freedb['EXTD'], "\\nYEAR:")
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
