-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sat, 03 Dec 2005 09:05:49 -0800 Russ Allbery <[EMAIL PROTECTED]> wrote:
> The opening of a new bug is fine, but you didn't do the other things > that I asked in #245015, namely answer the questions that I asked in > that bug log. I apologise for my rude behavior. Indeed, the earlier bug-closing was due to my failure to respond. I'll try to make up for that now... :-) > I'd really appreciate it if you would answer those > questions. Namely: > > * WHAT exactly fails? Please explain what error messages you got, or > other unexpected behavior, and why this is a failure. Here is the complete output of a failed compile: [EMAIL PROTECTED]:~/src/linux/linux-modules/openafs$ KSRC=/usr/src/linux-headers-2.6.14-2-386 KPKG_DEST_DIR="\$(CURDIR)/.." KDREV="0.99.jones1" fakeroot debian/rules kdist_configure kdist_image sh debian/prep-modules /usr/src/linux-headers-2.6.14-2-386 debian/control.module-image > debian/control sed: -e expression #1, char 14: unterminated `s' command make: *** [configure-modules-stamp] Error 1 I suspect that the cause of the problem is lack of escaping the embedded quoting when reused. Hacking a bit shows this: bash -x debian/prep-modules /usr/src/linux-headers-2.6.14-2-386 debian/control.module-image > debian/control + set -e + '[' 2 -ne 2 ']' + changelog=/usr/src/linux-headers-2.6.14-2-386/debian/changelog + '[' -n '`perl -e '\''$_ = <>; $_ =~ m/"(.+)"/; print "$1 \n";'\'' /usr/src/linux-headers-2.6.14-2-386/include/linux/version.h 2> /dev/null`' ']' + '[' -n 0.99.jones1 ']' + linuxversion='`perl -e '\''$_ = <>; $_ =~ m/"(.+)"/; print "$1 \n";'\'' /usr/src/linux-headers-2.6.14-2-386/include/linux/version.h 2> /dev/null`' + kernversion=0.99.jones1 ++ head -1 debian/changelog ++ sed -e 's/.*(\([^)]*\)).*/\1/' + pkgversion=1.4.0-1 ++ echo 1.4.0-1 ++ cut -d- -f 1 + pkgupversion=1.4.0 ++ perl -e '"1.4.0" =~ /(.*?)(\d+)\D*$/;printf $1 . ($2+1);' + pkgupversion2=1.4.1 + sed -e 's/=KVERS/`perl' -e ''\''$_' = '<>;' '$_' '=~' 'm/"(.+)"/;' print '"$1 \n";'\''' /usr/src/linux-headers-2.6.14-2-386/include/linux/version.h '2>' '/dev/null`/g' -e s/=KREVS/0.99.jones1/g -e s/=AVERS/1.4.0/g -e s/=2AVERS/1.4.1/g debian/control.module-image sed: -e expression #1, char 14: unterminated `s' command make: *** [configure-modules-stamp] Error 1 > * WHY does this patch fix the problem? If you're overriding KSRC > anyway, why does it matter whether the old definition binds early or > late? If my guess is right, then resolving once rather than passing on the rather complex shell contruct requires all places using it to deal very carefully with quoting/escaping, I believe. All I know for sure is that changing that single line causes my build to succeed. And even for the most advanced compilation constructs I cannot imagine it needed for the resolving to happen late: Do OpenAFS ever need to switch between several kernel version numbers in the middle of a single build?!? > I closed the previous bug because I asked these questions and you > never responded. I was quite busy the months after you stepped in and requested additional info. Also, I had a feeling that Sam did not really read my bugreport. How would you compile against official powerpc kernels as laid out in Sarge without passing KDREV? I tried again now that the official kernels have restructured and we could discuss this separately from KDREV as it is no longer required. I am currently working (in cooperation with Manoj and the kernel team) on this: http://wiki.debian.org/KernelModulesPackaging - Jonas - -- * Jonas Smedegaard - idealist og Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ - Enden er nær: http://www.shibumi.org/eoti.htm -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFDkeUQn7DbMsAkQLgRAlOaAJ4nN0Ou6NvX/DugcExA6PxSpc7nkQCcCl25 nfsGrSONnWnwTUniVqMHIWI= =wEk+ -----END PGP SIGNATURE-----
