On Sun, 12 Oct 2014 23:20:44 +0200 Emmanuel Bourg <ebo...@apache.org> wrote:
> Le 12/10/2014 22:14, Andrew Ayer a écrit : > > > * Sets the timestamp of every Zip entry to January 1, 1980 (the > > earliest date that can be represented in a Zip archive). > > Would it be possible to set the timestamp to the release date in > debian/changelog instead please? Sometimes when debugging tricky > issues I have found useful to know the build time of a jar. Yes, this is possible and we'll do it. > Note that some java packages also produces jar files with the .war and > .hpi extension, you may want to extend your processing to them. Will do, thanks. > > * Lexicographically sorts the Zip entries by filename, while > > keeping META-INF/ and META-INF/MANIFEST.MF at the beginning. > > Ok > > Regarding the MANIFEST.MF file, you may want to remove the > Bnd-LastModified field (another timestamp) and the Built-By field (it > contains the system username). Thanks for alerting me to these. We haven't come across these yet, but it's good to be proactive :-). > > * Removes the timestamp comment from Javadoc-generated .html files > > in the Jar file. > > I was planning to add the -notimestamp option to the javadoc calls, > but this solution is fine. I just hope it doesn't slow the build too > much. Passing -notimestamp to javadoc is preferable to stripping the timestamp after the fact, so please still add the -notimestamp option to the javadoc calls. dh_strip_nondeterminism will take a faster codepath if doesn't see the timestamp near the beginning of the html file, which should hopefully avoid slowing the build too much. The reason why we still want dh_strip_nondeterminism to strip out these timestamps is because of packages calling javadoc outside of javahelper. If it slows down the build despite the fast path, we can add a command line argument to dh_strip_nondeterminism to disable javadoc processing, and javahelper could set it with add_command_options. -- Andrew -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org