Any idea about this patch?

On Tue, Sep 30, 2014 at 4:07 AM, Richard B. Kreckel <krec...@ginac.de> wrote:
> On 09/25/2014 08:40 AM, YunQiang Su wrote:
>> I tested this patch. It fixes more.
>>
>> __mips64 defines for both N32 and N64, so we should use __LP64__ to 
>> determine.
>>
>> Both big- and little- endian define __mips__,so
>> __mips__ || __mipsel__ is not needed.
>
> Wait a minute. If I am not mistaken, __mips64__ should be defined by the
> configure script in include/cln/host_cpu.h, generated from
> include/cln/host_cpu.h.in. What does include/cln/host_cpu.h look like on
> your machine?
>
> Moreover, in your patch for include/cln/types.h, the parenthesis appear
> to be wrong.
>
>   -richard.
> --
> Richard B. Kreckel
> <http://in.terlu.de/~kreckel/>
>



-- 
YunQiang Su
Index: cln-1.3.3/m4/general.m4
===================================================================
--- cln-1.3.3.orig/m4/general.m4        2034-12-02 20:27:27.723746593 +0800
+++ cln-1.3.3/m4/general.m4     2034-12-02 20:28:04.094843192 +0800
@@ -153,7 +153,7 @@
     host_cpu=arm
     ;;
 changequote([,])dnl
-  mips )
+  mips* )
     AC_CACHE_CHECK([for 64-bit MIPS], cl_cv_host_mips64, [
 AC_EGREP_CPP(yes,
 [#if defined(_MIPS_SZLONG)
Index: cln-1.3.3/include/cln/object.h
===================================================================
--- cln-1.3.3.orig/include/cln/object.h 2034-12-02 20:27:27.708121592 +0800
+++ cln-1.3.3/include/cln/object.h      2034-12-02 20:31:01.571419597 +0800
@@ -22,7 +22,7 @@
 #if defined(__m68k__)
   #define cl_word_alignment  2
 #endif
-#if defined(__i386__) || defined(__mips__) || defined(__mipsel__) || 
(defined(__sparc__) && !defined(__arch64__)) || defined(__hppa__) || 
defined(__arm__) || defined(__rs6000__) || defined(__m88k__) || 
defined(__convex__) || (defined(__s390__) && !defined(__s390x__)) || 
defined(__sh__) || (defined(__x86_64__) && defined(__ILP32__))
+#if defined(__i386__) || (defined(__mips__) && !defined(__LP64__)) || 
(defined(__sparc__) && !defined(__arch64__)) || defined(__hppa__) || 
defined(__arm__) || defined(__rs6000__) || defined(__m88k__) || 
defined(__convex__) || (defined(__s390__) && !defined(__s390x__)) || 
defined(__sh__) || (defined(__x86_64__) && defined(__ILP32__))
   #define cl_word_alignment  4
 #endif
 #if defined(__alpha__) || defined(__ia64__) || defined(__mips64__) || 
defined(__powerpc64__) || (defined(__sparc__) && defined(__arch64__)) || 
(defined(__x86_64__) && !defined(__ILP32__)) || defined(__s390x__) || 
defined(__aarch64__)
Index: cln-1.3.3/include/cln/types.h
===================================================================
--- cln-1.3.3.orig/include/cln/types.h  2034-12-02 20:27:27.715934093 +0800
+++ cln-1.3.3/include/cln/types.h       2034-12-02 20:34:42.946436939 +0800
@@ -76,7 +76,7 @@
 
 // Integer type used for counters.
 // Constraint: sizeof(uintC) >= sizeof(uintL)
-  #if (defined(HAVE_FAST_LONGLONG) && (defined(__alpha__) || defined(__ia64__) 
|| defined(__powerpc64__) || defined(__s390x__) || (defined(__sparc__) && 
defined(__arch64__)) || defined(__x86_64__) || defined(__aarch64__)))
+  #if (defined(HAVE_FAST_LONGLONG) && (defined(__alpha__) || defined(__ia64__) 
|| defined(__powerpc64__) || defined(__s390x__) || (defined(__sparc__) && 
defined(__arch64__)) || defined(__x86_64__) || defined(__aarch64__) || 
defined(__mips64__)))
     #define intCsize long_bitsize
     typedef long           sintC;
     typedef unsigned long  uintC;
@@ -127,7 +127,7 @@
     typedef int sintD;
     typedef unsigned int uintD;
   #else  // we are not using GMP, so just guess something reasonable
-    #if (defined(HAVE_FAST_LONGLONG) && (defined(__alpha__) || 
defined(__ia64__) || defined(__powerpc64__) || (defined(__sparc__) && 
defined(__arch64__)) || defined(__s390x__) || defined(__x86_64__) || 
defined(__aarch64__)))
+    #if (defined(HAVE_FAST_LONGLONG) && (defined(__alpha__) || 
defined(__ia64__) || defined(__powerpc64__) || (defined(__sparc__) && 
defined(__arch64__)) || defined(__s390x__) || defined(__x86_64__) || 
defined(__aarch64__) || defined(__mips64__)))
       #define intDsize 64
       typedef sint64  sintD;
       typedef uint64  uintD;

Reply via email to