Package: xen-tools
Version: 4.4-1
Severity: wishlist
Tags: patch

xen-create-image has this option:

  --password=passphrase
      Set the root password for the new guest.

and it also has this option:

  --genpass=1  Generate a random root password (default, set to 0 to turn off)

Well. I tried using --password alone and it didn't work.
Apparently I have to use both options:

--password=mypassword --genpass=0 

which IMHO is counter-intuitive: If I explicitly set the password it
should be already clear that I don't have one to be generated at
random.

So, I suggest that using --password should be enough.

I don't speak perl, but maybe something like this:

diff --git a/xen-tools-4.4/bin/xen-create-image 
b/xen-tools-4.4/bin/xen-create-image
index c52a37a..cf7ded6 100755
--- a/xen-tools-4.4/bin/xen-create-image
+++ b/xen-tools-4.4/bin/xen-create-image
@@ -167,6 +167,7 @@ and EVMS EXAMPLE.
 
    --password=passphrase
                 Set the root password for the new guest.
+                Note: This overrides --genpass
 
    --(no)passwd (Don't) ask for a root password interactively during
                 setup.  NOTE: This overrides --genpass --password.
@@ -3975,7 +3976,7 @@ sub setupRootPassword
             #
             #  Generate a password, salt and use that to generating a hash
             #
-            if ( $CONFIG{ 'genpass' } )
+            if ( $CONFIG{ 'genpass' } and !defined( $CONFIG{ 'password' } ) )
             {
                 $PASSWORD = generatePassword( $CONFIG{ 'genpass_len' } );
             }

Thanks.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to