Package: gkrellmd
Version: 2.3.5-6+b1
Severity: important
Tags: patch ipv6
Dear Maintainer,
* What led up to the situation?
Connecting to gkrellmd via IPv6
* What exactly did you do (or not do) that was effective (or
ineffective)?
Specified an allow-host line in the config file to match my subnet,
in the form: allow-host 2001:470:xxxx:xxxx::/64
* What was the outcome of this action?
"Connection not allowed from <client IPv6 address>"
* What outcome did you expect instead?
The client to connect
The part of cidr_match() in server/main.c which checks prefixes uses strtoul(),
checking errno afterwards, but does not set errno to 0 beforehand, as is
necessary.
-- System Information:
Debian Release: jessie/sid
APT prefers testing-updates
APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16.1 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages gkrellmd depends on:
ii adduser 3.113+nmu3
ii libc6 2.19-11
ii libglib2.0-0 2.42.0-1
ii libsensors4 1:3.3.5-2
gkrellmd recommends no packages.
gkrellmd suggests no packages.
-- no debconf information
--- server/main.c.orig 2014-06-23 06:55:17.000000000 +0100
+++ server/main.c 2014-10-04 14:34:35.269994555 +0100
@@ -360,6 +360,7 @@
plen = -1;
if ((p = strchr(buf, '/')) != NULL)
{
+ errno = 0;
plen = strtoul(p + 1, &ep, 10);
if (errno != 0 || ep == NULL || *ep != '\0' || plen < 0)
{
