Control: tags -1 patch

Hi,

On Sat, Sep 27, 2014 at 03:14:20PM -0400, David Prévot wrote:
> Package: glpi

> From a quick overlook, it seems like inc/notificationmail.class.php is
> relying on “require_once(GLPI_PHPMAILER_DIR . "/class.phpmailer.php");”
> to get all needed classes (including, e.g., the SMTP one, as provided by
> class.smtp.php).

A closer look and some tests confirmed this assumption.

> Starting with libphp-phpmailer 5.2.9+dfsg-1 […]
> the autoloader code present in class.phpmailer.php
> has been removed by upstream

Please find attached a trivial and tested patch that ensures the needed
SMTP class gets loaded.

> Thanks in advance if you can fix this issue quickly enough, so we may
> ship the latest libphp-phpmailer version in Jessie.

glpi is the only package currently in testing that would be affected by
this issue (i.e., not being able to send mail with a configured SMTP
Mail server in the Email Notifications Setup).

Please let me know if you can’t upload this fix in a timely manner
(sorry for the hurry, but the freeze is pretty close now), I’d be happy
to NMU it if you don’t mind.

Regards

David
Description: Don’t rely on class.phpmailer.php to act as an autoloader
 Starting with libphp-phpmailer 5.2.9+dfsg-1, the autoloader code that
 was present in class.phpmailer.php has been removed by upstream.
 .
 In order to use the SMTP features, class.smtp.php must now be loaded
 explicitly.
Author: David Prévot <taf...@debian.org>
Bug-Debian: https://bugs.debian.org/763084
Last-Update: 2014-09-27
--- a/inc/notificationmail.class.php
+++ b/inc/notificationmail.class.php
@@ -36,6 +36,7 @@
 }
 
 require_once(GLPI_PHPMAILER_DIR . "/class.phpmailer.php");
+require_once(GLPI_PHPMAILER_DIR . "/class.smtp.php");
 
 /**
  *  NotificationMail class extends phpmail and implements the NotificationInterface

Attachment: signature.asc
Description: Digital signature

Reply via email to