Package: argyll
Version: 1.6.3-1
Severity: normal

Hi,

I noticed that argyll ships the following patch:

debian/patches/03_usb-db.diff

 # Set ID_VENDOR and ID_MODEL acording to VID and PID
 -TEST=="/lib/udev/usb-db", IMPORT{program}="usb-db %p"
 +TEST=="/lib/udev/usb-db", IMPORT{builtin}="hwdb --subsystem=usb"

It's true that usb-db is history and no longer exists. But given that,
the patch doesn't make a lot of sense to me.

You are testing for /lib/udev/usb-db, which no longer exists, to then
run the hwdb builtin, which will never be run as the TEST will never be
true.

What's the purpose of this patch?

I see that you referenced https://bugs.launchpad.net/bugs/1200185 in
this patch, so bringing Martin and Dimitri into the loop here.

[1] 
http://anonscm.debian.org/cgit/collab-maint/argyll.git/tree/debian/patches/03_usb-db.diff
-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages argyll depends on:
ii  libc6         2.19-11
ii  libicc2       2.12+argyll1.5.1-8
ii  libimdi0      1.5.1-8
ii  libjpeg8      8d1-1
ii  libtiff5      4.0.3-10
ii  libusb-0.1-4  2:0.1.12-24
ii  libx11-6      2:1.6.2-3
ii  libxext6      2:1.3.2-1
ii  libxinerama1  2:1.1.3-1
ii  libxrandr2    2:1.4.2-1
ii  libxss1       1:1.2.2-1
ii  libxxf86vm1   1:1.1.3-1

Versions of packages argyll recommends:
ii  libpam-systemd  215-4
ii  udev            215-4

Versions of packages argyll suggests:
ii  colord                1.2.1-1
pn  gir1.2-colordgtk-1.0  <none>

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to