Hi, first of all for the bug report and the suggestions. I am working in including them.
On Sat, Sep 6, 2014 at 3:22 PM, roma1390 <roma1...@gmail.com> wrote: > 1. general naming must be followed, and script named like other update-* > scripts > > update-geoip-database-contrib I am not sure it is a *must* (I could not find this in the Debian policy, for example). The reason it is called geoip-database-contrib_update is that I find it helpful when the commands in a package start with the package name. However I see your point and I will also support the name you are suggesting. > 2. file update has race conditions: > - file is removed and later downloaded > - file decompresion is in place, this exposes partial file to user > > 3. file download-update is not safe: wget can get redirect and name file > with any name. > so in /usr/share/GeoIP can be found files like index.html and others... > > 4. write is done to /usr which is many cases can safely be assumed that is > read-only Make sense, fixing all of the above. > Suggestions: > > 1. place databases to /var/lib/cache/GeoIP/ I am assuming you meant /var/cache/GeoIP. /var/cache is not the best place because if you remove that it it will not be re-created until the update script is run again. However /var/lib/geo-ip-database-contrib sounds good to me. Thanks, Ludovico -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
