Le 11/09/2014 14:16, Axel Beckert a écrit : > Package: libplplot-dev > Version: 5.10.0-0.1 > Severity: important > > Hi, > > while preparing the gnudatalanguage upload yesterday, I noticed the > following: > > /usr/include/plplot/plConfig.h tries to include plplot_config.h, but > that file is not shipped in the package: > > 47 #ifdef HAVE_CONFIG_H > 48 # include <plplot_config.h> > 49 #endif
Dear Axel, This is what plplot_config.h has to say: // Configured (by CMake) macros for PLplot that are required for the // core build but _not_ required for the build of the installed // examples (and presumably any user applications). Therefore, the // configured plplot_config.h should not be installed. In contrast, // include/plConfig.h.in (note, the configured plConfig.h result // #includes plplot_config.h for the core build because HAVE_CONFIG_H // is #defined in that case) contains configured macros that are // required for the core build, installed examples build, and build of // user applications. Therefore, in contrast to plplot_config.h, // plConfig.h should be installed. // // Maintenance issue: in makes no sense to configure duplicate macros // for both plplot_config.h and plConfig.h. Therefore, when adding a macro // decide which file to put it in depending on whether the result is // needed for the installed examples build or not. Furthermore, move // configured macros from one file to the other as needed depending on // that criterion, but do not copy them. // Actually, there is no config.h in Wheezy's libplplot-dev. Chances are gnudatalanguage was taking another config.h (perhaps its own), which is quite dangerous. Based on that, I would say the right fix is no patch plConfig.h to contain the macros you need, and not use -DHAVE_CONFIG_H. #ifdef HAVE_CONFIG_H # define HAD_CONFIG_H #endif #include <plConfig.h> #ifdef HAD_CONFIG_H # define HAVE_CONFIG_H # undef HAD_CONFIG_H #endif Actually, the be fix may be to patch the installed version of plConfig.h to not include plplot_config.h. Kind regards, Thibaut.
signature.asc
Description: OpenPGP digital signature
