Le samedi 22 septembre 2012 à 22:07 +0100, Michael Tautschnig a écrit :
> Package: hping3
> Version: 3.a2.ds2-6
> 
> While compiling the package using our research compiler infrastructure we
> noticed the following conflicting declaration of the variable ip_optlen:
> 
> - globals.h: extern char ip_optlen;
> - main.c: unsigned ip_optlen;

> This will cause undefined behaviour if the value of ip_optlen exceeds 127 for
> any architecture with signed char type. This is also problematic in other 
> cases
> where ip_optlen stores the return value of functions returning unsigned char.

Good catch. I understand the possible collision, but i don't measure
well the real impact in the source code.

Hping3 author is not active anymore on this project and i can only
maintain the packaging or minor modifications, so unless there is a
blocker issue, i'll not investigate the problem further (but another
patch for hping3 could be integrated in Debian if someone want to take
the time).

Thanks.

> 
> Best,
> Michael
> 

-- 
Guillaume Delacour <g...@iroqwa.org>

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to