Hi Tobias
> Il Domenica 31 Agosto 2014 14:15, Tobias Frost <t...@debian.org> ha scritto: > > On Fri, 2014-08-29 at 08:23 +0100, Gianfranco Costamagna wrote: >> Hi Tobias, sorry for top posting, I'm on vac and mobile :-) >> >> The reason for the VCS not created is that I'm not yet in the ubuntu >> unity team, so I don't have write permissions to create it :-) >> >> I'll talk to sil how does he feel about maintaining in >> collab-maint/git! >> >> As you can see I'm a proud git and git-buildpackage user, so I'll >> benefit a lot from the git usage :-) >> >> In the meanwhile feel free to drop them, the new upstream release I >> think will come shortly (basically I got accepted all my patches and I >> think we have testsuite working on git right now, I tested it a little >> bit). >> >> So we can add CVS in the second upload, I'll also try to use the >> system gconv rather than the (working) embedded one! >> >> Have many thanks for your time! >> >> Gianfranco >> >> Sent from Yahoo Mail on Android >> >> > > > > > Hi Gianfranco, > > Yes, collab-maint would be indeed the best option and can be done after > the initial upload. So just remove VCS-* for now and re-add once you've > decided how to go on. > Removed > Back to the package. Sorry, took me longer than expected to take deeper > look, but the review should be complete now. So I think this will be the > last iteration... > > During the review of d/copyright I found those mismatches which might > need clarification: > > -> ./src/contrib/analyzers/common/analysis/ar/ArabicAnalyzer.cpp > ./src/contrib/analyzers/common/analysis/fa/PersianAnalyzer.cpp > seems to be generated from BSD Data. Not sure how they have been > generated and what is the effective license is indeed tricky. Can you > check with upstream how the data is processed and if that is enough to > constitute a new copyright? (However, It would be best if the files > could be autogenerated at build time and the stoplist file distributed > with the tarball.) > For now, I'd recommend to add an comment to d/copyright stating that the > file has been created using BSD-Licensed data from http://... https://github.com/luceneplusplus/LucenePlusPlus/issues/70 > > -> ./src/contrib/snowball/libstemmer_c/* is missing in d/copyright and > it is (as far as can see) an embedded code copy. (Debian source package > snowball). As convenience copies are strongly discouraged, please try to > patch lucene so it will link against the package version. > (If you find out, this is not feasible, please let me know along with > your reasoning) > https://github.com/luceneplusplus/LucenePlusPlus/issues/71 > So, this seems now to be the last two points to be fixed. Then I'll > upload it :) > thanks again, I opened the two above upstream issues, because the problem is not debian-specific and I'm not in the position of force a system library when a custom delta might be needed (and moreover I don't see it used, as I wrote on the issue). So I'll update as soon as I get upstream feedbacks! Cheers! G. > > -- > tobi > -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
