Bug#341161: aptitude: segfault trying to install xprt and xprt-common

[Daniel Burrows]

severity 341161 normal
merge 341161 340385
thanks

On Mon, Nov 28, 2005 at 08:14:25PM +0000, Chris Boyle <[EMAIL PROTECTED]> was 
heard to say:
> I started aptitude, selected xprt-common and then xprt for installation,
> pressed g to get the preview, pressed g again, accepted the security
> warning, and got a segfault. The previous states of the packages:
> 
> un  xprt           <none>         (no description available)
> rc  xprt-common    0.1.0.alpha1-8 Xprint - the X11 print system (configuration
> 
> The window was not copy-pasteable, so the trace can be seen at
> http://cmb.is-a-geek.org/images/aptitude-xprt-segv.png

  This sounds like #340385.  If possible, could you verify that it's fixed
by applying the attached patch?

    Thanks,
  Daniel

Thu Nov 24 13:59:16 CST 2005  Daniel Burrows <[EMAIL PROTECTED]>
  * Don't ever explicitly select as a candidate a version that exists only 
because a package was removed and not purged. (Closes: #340385)
diff -rN -udp old-head/src/generic/apt/aptcache.cc 
new-head/src/generic/apt/aptcache.cc
--- old-head/src/generic/apt/aptcache.cc        2005-11-28 14:54:59.000000000 
-0600
+++ new-head/src/generic/apt/aptcache.cc        2005-11-24 13:56:04.000000000 
-0600
@@ -934,7 +934,10 @@ void aptitudeDepCache::set_candidate_ver
 
   dirty=true;
 
-  if(!ver.end())
+  if(!ver.end() &&
+     (ver.Downloadable() ||
+      (ver == ver.ParentPkg().CurrentVer() &&
+       ver.ParentPkg()->CurrentState != pkgCache::State::ConfigFiles)))
     {
       pre_package_state_changed();
       // Use the InstVerIter instead of GetCandidateVersion, since

signature.asc
Description: Digital signature