On Sat, Nov 26, 2005 at 04:06:42PM +0100, Bernhard Reiter wrote: > On Sun, Nov 13, 2005 at 06:33:05PM +0100, Lionel Elie Mamane wrote:
>> I can't find a patch that seems to address one of these issues only >> (or both issues) on your FTP directory. Which one are you referring to? > http://ftp.intevation.de/users/bernhard/mailman/mailman-2.1.4-avoid-headerfolding-python21.diff I'm not sure how I missed it, I think I saw "2.1.4" and unconsciously treated it as obsolete stuff. I took a look at the patch. In the class "Generator" you define, you completely ignore the argument mangle_from to __init__. If it is not used, I would expect it not to be taken as an argument of __init__ at all. Or, on the contrary, to be used and passed to the email.Generator.Generator.__init__ call. It is probably best to pass it to email.Generator.Generator.__init__, and set it to "False" in all instances where one writes to a one-message file or to a string (nearly everywhere) and to "True" when one writes to a mailbox (in Mailman/Mailbox.py). Current OpenPGP implementations do 'From '-mangling themselves anyway before clearsigning. I dunno whether S/MIME implementations do, too. Same story for the max_header_len argument; shouldn't we rather put the default value to 0 and pass the argument to email.Generator.Generator.__init__? This would avoid overwriting _write_headers. Could you please comment on that? Thanks. -- Lionel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
