Hi Eriberto, On Wed, Aug 13, 2014 at 08:32:55PM -0300, Eriberto wrote: > Hi Luis, > > Sorry for my delay and congratulations for your work. I agree with > your considerations.
Again, thanks a *lot* for reviewing my xombrero package! > However, I didn't see the general licensing in > your d/copyright. Right, I've actually updated a few things in the copyright file but looks like I didn't quite understood the approach you were suggesting: > > The common situation is put 'Files: *' and 'Files: debian/*' to refer > to general licenses and add, if necessary, special cases. You can see > a simple example at > http://metadata.ftp-master.debian.org/changelogs/main/h/heartbleeder/unstable_copyright > > You needn't list all files and its licenses. You can quote the main > authors and the range of years in 'Files: *'; after this you must list > the exceptions. So, the xombrero.{1,c,conf,css,desktop,h} (main > files) have a list of the authors and some years. So, I expected to > see something as this text in your d/copyright: > > Files: * > Copyright: 2010-2012 Marco Peereboom <ma...@peereboom.us> > Edd Barrett <vex...@gmail.com> > 2011 Conformal Systems LLC <i...@conformal.com> > Jason McIntyre <j...@openbsd.org> > Michal Mazurek <akf...@jasminek.net> > Raphael Graf <r...@undefined.ch> > Stevan Andjelkovic > <ste...@student.chalmers.se> > Todd T. Fries <t...@fries.net> > 2012-2013 Josh Rickmar <jr...@devio.us> > 2013 David Hill <dh...@mindcry.org> > License: ISC > Ok, so you're suggesting that I should group most of the names/years in the same copyright '*' pattern. I tried to follow a completely different approach (which I used for the xxxterm package), that provides (imho) more accurate information. For example, in your example above, I would interpret it as having file 'xombrero.css' copyrighted by all those authors, even if the real copyright owner is only Josh Rickmar; the same is true for the xombrero.1 file: the only copyright owners are Marco Peereboom, Jason McIntyre and Josh Rickmar. My debian/copyright contains more detailed information, that allows to know exactly who owns the copyright for each file individually. Of course I do group some of the files, but the copyrights are so different between different files that I decided not to use the 'Files: *' pattern (although I use the 'Files: debian/*' pattern). Anyway, I'm OK following the approach you're suggesting -- I just want to confirm that my understanding is correct and this is exactly what you want me to do. <snip> > > I have two doubts: > > Where you saw that the files style.css, *.png, tordisabled.ico and > torenabled.ico are using the CC-BY-SA license? > The license for the style.css is mentioned in the xombrero website (https://opensource.conformal.com/wiki/xombrero). Regarding the tor icons, they are reused from the tor project and the terms and license we're taken from the project website (https://www.torproject.org/). Finally, the *png files licenses were confirmed in private emails with the xombrero project developers (iirc, when I first packaged xxxterm there was not public mailing list yet). > Where you found *.xpm files? > Ah, this one is generated my me in debian/rules from the xpm files. Cheers, -- Luis > Cheers, > > Eriberto > > > 2014-08-11 17:54 GMT-03:00 Luis Henriques <hen...@camandro.org>: > > Hi Eriberto, > > On Wed, Aug 06, 2014 at 05:19:31PM -0300, Eriberto Mota wrote: > >> tags 757176 moreinfo > >> thanks > >> > >> Hi Luis Henriques, > >> > >> Please: > >> > > > > First of all, thank you a lot for your review. I've already gone through > > all your comments and I've uploaded a new xombrero package into > > mentors.debian.net that contains most of your comments implemented. > > > > Comments inline below: > > > >> 1. d/control, in package xxxterm: > >> > >> - Change the section from oldlibs to web. > >> - Change priority extra to optional. > > > > According to the Debian Developer's Reference, section 6.7.7. ("Make > > transition packages deborphan compliant"): > > > > "Also, it is recommended to adjust its section to oldlibs and its > > priority to extra in order to ease deborphan's job." > > > > Also, if I implement these 2 changes, I get additional lintian warnings > > such as transitional-package-should-be-oldlibs-extra: > > > > The package appears to be a transitional package, but it is not priority > > extra and in the oldlibs section. > > > > Using oldlibs/extra assists package managers in handling the transition > > package correctly. > > > > Refer to http://bugs.debian.org/645438 and Debian Developer's Reference > > section 6.7.7 (Make transition packages deborphan compliant) for > > details. > > > > So, I've decided not to include these 2 fields changed in the > > debian/control file. Please let me know if you disagree with my position. > > > >> - In short description, remove the word 'rename'. > >> As long description, use only: > >> > >> This is a transitional dummy package to xombrero. It can safely be > >> removed. > >> > >> The last change is to discourage the install of the xxxterm. So, the > >> text needs to be short and direct. > >> > > > > Done! > > > >> 2. d/copyright: update all information, even the packaging years. In > >> the upstream code, you need to check file by file. Please, fix the > >> line that says "Copyright (c) 2013 David Hill <dh...@mindcry.org>". > >> > > > > Done. > > > >> 3. I think that d/docs can be removed, because all relevant > >> information are in manpage. > >> > > > > Done. > > > >> 4. In d/news, please, remove the header. > >> > > > > Actually, I've renamed the NEWS file with a NEWS.Debian file -- which was > > what I meant in the first place. Thus, I've kept the header as per the > > example in the Debian Developer's Reference, section 6.3.4. > > ("Supplementing changelogs with NEWS.Debian files"). > > > >> 5. d/rules: remove useless lines '# debian/rules makefile that uses > >> debhelper.' and '# Uncomment this to turn on verbose mode.'. > >> > > > > Done. > > > >> 6. d/rules: after the 'export DH_VERBOSE=1' line, put: > >> > >> export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed > >> > >> It will fix this situation: > >> > >> dpkg-shlibdeps: warning: package could avoid a useless dependency if > >> debian/xombrero/usr/bin/xombrero was not linked against > >> libcairo-gobject.so.2 (it uses none of the library's symbols) > >> dpkg-shlibdeps: warning: package could avoid a useless dependency if > >> debian/xombrero/usr/bin/xombrero was not linked against libX11.so.6 > >> (it uses none of the library's symbols) > >> dpkg-shlibdeps: warning: package could avoid a useless dependency if > >> debian/xombrero/usr/bin/xombrero was not linked against > >> libatk-1.0.so.0 (it uses none of the library's symbols) > >> dpkg-shlibdeps: warning: package could avoid a useless dependency if > >> debian/xombrero/usr/bin/xombrero was not linked against > >> libpangocairo-1.0.so.0 (it uses none of the library's symbols) > >> dpkg-shlibdeps: warning: package could avoid a useless dependency if > >> debian/xombrero/usr/bin/xombrero was not linked against libcairo.so.2 > >> (it uses none of the library's symbols) > >> > > > > Done. > > > >> 7. You have several bugs not treated[1]. Please, try to solve and > >> close some bugs. The bug #695874 is easy and mandatory to be closed by > >> your package. > >> > > > > Done, I've include several bugs in the changelog. I also plan to ping the > > reporters of the other open xxxterm bugs to check if they still experience > > those issues with newer versions of the package (xombrero). > > > > Now, the problem is that I see the following in mentors.debian.net: > > > > Package closes bugs in a wrong way > > > > Errors: > > - Bug #695874 does not belong to this package > > - Bug #752313 does not belong to this package > > > > xxxterm: > > #695874 (normal): xxxterm renamed to xombrero, new versions available > > #752313 (normal): xxxterm: Please build against libgnutls28-dev > > > > > > Since lintian didn't actually complained, I'm not sure if this is an issue > > or not. > > > >> Thanks for your work. I will wait you. > >> > > > > Again, thanks a *lot* for reviewing my package! > > > > Cheers, > > -- > > Luis > > > >> Cheers, > >> > >> Eriberto > >> > >> [1] > >> https://bugs.debian.org/cgi-bin/pkgreport.cgi?repeatmerged=no&src=xxxterm > >> [2] > >> > >> > >> 2014-08-05 20:40 GMT-03:00 Luis Henriques <hen...@camandro.org>: > >> > > >> > I am looking for a sponsor for my package "xombrero" > >> > > >> > >> > >> -- > >> To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org > >> with a subject of "unsubscribe". Trouble? Contact > >> listmas...@lists.debian.org > >> Archive: > >> https://lists.debian.org/CAP+dXJf4d++1ePRNqen_=rbmyqlvdustzvjjrznhuvf3ut-...@mail.gmail.com > >> -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
