Package: buildbot
Version: 0.8.9-1
Severity: normal

Dear Maintainer,

if buildmaster configuration contains an error, the operation
service buildmaster restart
shows [ OK ].

It seems that the culprit is the --quiet parameters of buildbot restart
command called from the init script, as it suppresses the return code.
When the option is removed, the exit code is correctly set.

Possible fix: change the buildbot restart call in master_op() to remove
--quiet and redirect the output streams to /dev/null.

Or maybe report the issue upstream and have the quiet option fixed.

I tested it on buildmaster, but maybe the same logic applies to buildslave.

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (850, 'testing'), (800, 'unstable'), (750, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages buildbot depends on:
ii  adduser               3.113+nmu3
ii  dpkg                  1.17.10
ii  libjs-sphinxdoc       1.2.2+dfsg-2
ii  python                2.7.8-1
ii  python-dateutil       1.5+dfsg-1
ii  python-jinja2         2.7.3-1
ii  python-migrate        0.9.1-1
ii  python-sqlalchemy     0.9.7-1
ii  python-twisted        14.0.0-2
ii  python-twisted-core   14.0.0-2
ii  python-twisted-web    14.0.0-2
ii  python-twisted-words  14.0.0-2

Versions of packages buildbot recommends:
ii  buildbot-slave       0.8.9-1
ii  libaprutil1          1.5.3-2
ii  python-twisted-mail  14.0.0-2

Versions of packages buildbot suggests:
ii  bzr         2.6.0+bzr6595-1
ii  cvs         2:1.12.13+real-14
ii  git         1:2.1.0~rc1-1
ii  mercurial   3.0.2-1
ii  subversion  1.8.9-2

-- Configuration Files:
/etc/default/buildmaster changed [not included]
/etc/init.d/buildmaster changed [not included]

-- no debconf information


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to