Hi Andreas,
I was reading the code and checking your patch.
The variable MAX_CPU seems to be the maximum cpu number:
123 #define MAX_CPU (10) /* depends on graph height */
And is used in this block:
397 /* Load ding is 45 pixels hoog */
398 copyXPMArea(0, 64, 32, 12, 28, 4);
399
400 if (i == 0 && nb_cpu > 1) {
401 if (nb_cpu > MAX_CPU || cpu_avg_max) {
402 /* show average CPU */
403 j = getWidth(stat_device[i].rt_stat, stat_device[i].rt_idle);
404 copyXPMArea(32, 64, j, 6, 28, 4);
405 /* Show max CPU */
406 j = getWidth(stat_device[i].cpu_stat[cpu_max],
407 stat_device[i].idle_stat[cpu_max]);
408 copyXPMArea(32, 70, j, 6, 28, 10);
409 } else {
410 int cpu;
411 for (cpu = 0; cpu < nb_cpu; cpu++) {
412 j = getWidth(stat_device[i].cpu_stat[cpu],
413 stat_device[i].idle_stat[cpu]);
414 copyXPMArea(32, 65, j,
415 MAX_CPU / nb_cpu, 28,
416 5 + (MAX_CPU / nb_cpu) * cpu);
417 }
418 }
419 } else {
420 j = getWidth(stat_device[i].rt_stat, stat_device[i].rt_idle);
421 copyXPMArea(32, 64, j, 12, 28, 4);
422 }
nm_cpu is the number of cpu's for your computer (12!! great).
You will use lines 400-418, because nb_cpu > 1. Your nb_cpu is 12 and
the MAX_CPU is 10, without a patch you will use lines 401-408, and
show only the average :-(
Take a look about the max height size, 12 (see line 398 or the 6+6 in
the copyXPMArea(32, 64, j, *6*, 28, 4) calls).
Ok, If we increase the MAX_CPU to 12 (more is not possible because the
max height is 12), then you will use the "else" block (lines 410-417),
and wmmon will paint every CPU.
I think is possible increase the value to 12, but I would like test it
first, to avoid wrong painting.
Please, could you test it?
If is ok, I would like to include it in the upstream
(repo.or.cz/dockapps.git). Feel free to create the upstream patch or,
if you can't, I will do it.
Thanks a lot,
Rodolfo.
Rodolfo García Peñas (kix)
http://www.kix.es/
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
