Hi Dariusz, reviewing.. As usual here an (unordered) list:
-> please read d/README.source and act accordingly :) -> d/copyright The source is dual-licensed. Please correct the license. The line Copyright (c) 2005-2009 Collecta, Inc. is misplaced (I think you wanted to put it two lines earlier) as this is not part of the license. Same below with the debian/* files. Regarding License.txt... They say "This program is dual licensed under the MIT *and* GPLv3 licenses." (emphasis by me) Do upstream mean "or" here? (I'm not sure if you can comply to both licenses at the same time; better ask debian-legal if the "and" is ok or if a sentence like "on your choice" is missing.) It would be anyway great if upstream could add a license header NOT refering to LICENSE.txt in every file ... as this could create problems if a file is to be used outside of libstrophe. It would be much clearer, also (As they link against openssl, they probably need the openssl exception when applying the GPL. Refer also to https://lists.debian.org/debian-legal/2002/10/msg00113.html) Shouldn't be a problem for MIT, but IANAL.) -> d/docs has the license text files and you exclude them in again in d/rules...This program is dual licensed under the MIT and GPLv3 licenses. -> why no symbols file? -> d/rules you should call bootstrap in override_dh_autoreconf, not in override_dh_auto_configure: override_dh_autoreconf: dh_autoreconf ./bootstrap.sh Then you also won't need to override autoclean. (I any prefer a clean file over overriding debhelper targets) (Also please unset DH_VERBOSE when uploading...) "unused substitution variable ${misc:Pre-Depends}" Pre-Depend is missing in d/control (multi-arch support...) -- tobi
signature.asc
Description: This is a digitally signed message part
