On 2014-08-10 12:12, Johannes Schauer wrote:
> Hi,
> 
> Quoting Niels Thykier (2014-08-10 10:39:48)
>
> 
> [...]

Thanks

>> Shouldn't this be quotemeta'ed as well? Otherwise "file.png" would
>> become eqv. to "file?png".
> 
> No, because the "." in file.png would match the third group and thus be
> quotemeta'ed. The fourth grouph which is not quotemeta'ed matches the escaped
> strings "\?", "\*" and "\\" which happen to be escaped the same way as a regex
> and thus do not need any more quoting.
> 
> Thanks a lot for your review! The fixed version is attached :)
> 
> cheers, josch
> 

Okay, what about other valid special regex characters? Like the
following (hopefully rare) file names

 * file-with-(something-in-parenthesis).png
 * or-perhaps-only-one-{-which-causes-a-compile-failure.png
 * even-]-is-not-safe.png
 * Perhaps-even-|-will-cause-problems.png
 * Lets-not-forget-^-and-$-for-added-fun.png

:)

~Niels


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to