Hi Eriberto, Thanks for reviewing the package.
On 03/08/14 03:36, Eriberto Mota wrote: > Hi Daniel, > > Please: > > 1. d/buildinotify.desktop.example has > 'Name[en_GB]=buildnotify.desktop.example' and 'Name=buildnotify'. Is > right it? (I think that must be 'Name=buildnotify.desktop.example') > I have made the two fields the same, both "buildnotify" (the program name) > 2. In d/rules remove the line '# -*- makefile -*-'. It is a useless comment. > > 3. Your package doesn't builds twice. So, allow the content > modification of the BuildNotify.egg-info/SOURCES.txt. To make it, > create the file debian/source/options with this content[1]: > > extend-diff-ignore = "^BuildNotify.egg-info/SOURCES.txt$" > Both done > 4. I suggest you add to long description a bit more of information. I > needed to access the upstream site to understand the program. Where > applicable, words as Gnome, KDE, etc. will improve the results when > doing an 'apt-cache search'. > I have added the list of features from upstream. I will admit I'm not the best when it comes to writing text like that! I haven't added any Gnome, KDE etc keywords, as the applet is designed to work independent of the desktop manager, but I'm welcome to further suggestions. > 5. In d/copyright, the better information is: "Copyright: 2009-2014, > Anay Nayak <anayak...@gmail.com>". This information can be viewed in > upstream VCS[2]. > Updated. > Thanks for your work. > No problem! I have uploaded a new package to mentors at the original location. https://mentors.debian.net/package/buildnotify http://mentors.debian.net/debian/pool/main/b/buildnotify/buildnotify_0.3.5-1.dsc Regards, Daniel
signature.asc
Description: OpenPGP digital signature
