Hi Jorg, Thanks for the review. It was worth a try.
If you'd rather wait until upstream takes the patch in, then I'm fine with that. The patch author has indicated to me that he has had a difficult time getting anyone from upstream to review his submission to help speed things along. If you know of anyone that can help upstream with getting the patch reviewed and accepted, then it will be appreciated. I wish I could give more specifics on the release dates of the hardware, but I can't. And to clarify, I did test the patches with 13G hardware, and have been doing so since I was aware of the patch. I placed too much emphasis in the Ubuntu bug on making sure 12G didn't regress since that's what's . I've also updated the Ubuntu bug to clarify this as well. Thanks for catching that and I apologize if it wasn't clear earlier. Also, any clarification you can provide that will help prevent 'spaghetti code' in the future will help be helpful. Thanks, again, for reviewing the patch and for the feedback. On Thu, Jul 31, 2014 at 5:22 PM, Jörg Frings-Fürst < deb...@jff-webhosting.net> wrote: > Hello Kent, > > first thanks for your work. > > > My personal comments: > > - A NMU 23 hours after opening the bug[1] and 10 hours after the last > maintainer action is really unusual [2]. > > - The patch has code, in german we call it "Spaghetti Code", which > produce a lot of overhead and it makes the sources cluttered and > difficult to maintain. > > - From your ubuntu bug[3]: "The 13G line of Dell PowerEdge servers > will be rolling out later this year." So I think that we have enough > time to make our job without any time pressure and how it is > required. > > - At[4] you have tested your changes on ubuntu. But only on 12G > hardware. Thus was only tested the 12G Code and with the results it > is concluded that the verification of the 13G codes are ok. > > > CU > Jörg > > > [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756555 > [2] > https://www.debian.org/doc/manuals/developers-reference/pkgs.html#nmu > [3] > https://bugs.launchpad.net/ubuntu/trusty/+source/ipmitool/+bug/1343407 > [4] > > https://bugs.launchpad.net/ubuntu/trusty/+source/ipmitool/+bug/1343407/comments/13 > > > -- > pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E > pgp Key: BE581B6E > CAcert Key S/N: 0E:D4:56 > > Jörg Frings-Fürst > D-54526 Niederkail > > Threema: SYR8SJXB > > IRC: j_...@freenode.net > j_...@oftc.net > > > > > >
