Package: ebook-tools Version: 0.2.2-3 Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu ubuntu-patch utopic User: autopkgtest-de...@lists.alioth.debian.org Usertags: autopkgtest
Hello, ebook-tool's autopkgtest currently succeeds in Debian, but fails in Ubuntu [1]: adt-run [05:19:29]: test build: [----------------------- /tmp/ccIgEbHv.o: In function `main': test-libepub.c:(.text+0x2a): undefined reference to `epub_open' test-libepub.c:(.text+0x65): undefined reference to `epub_close' collect2: error: ld returned 1 exit status That's because Ubuntu's gcc/binutils already use the stricter linking as with binutils-gold, where the order matters. (See https://wiki.debian.org/ToolChain/DSOLinking for details) Attached patch fixes the -l to come after the source that needs the library, which makes the test succeed with binutils-gold too. Thanks for considering, Martin [1] https://jenkins.qa.ubuntu.com/job/utopic-adt-ebook-tools/6/ARCH=i386,label=adt/console -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
diff -Nru ebook-tools-0.2.2/debian/changelog ebook-tools-0.2.2/debian/changelog --- ebook-tools-0.2.2/debian/changelog 2014-07-23 20:45:00.000000000 +0200 +++ ebook-tools-0.2.2/debian/changelog 2014-07-28 07:23:33.000000000 +0200 @@ -1,3 +1,9 @@ +ebook-tools (0.2.2-3ubuntu1) utopic; urgency=medium + + * Fix link order in "build" autopkgtest. + + -- Martin Pitt <martin.p...@ubuntu.com> Mon, 28 Jul 2014 07:23:24 +0200 + ebook-tools (0.2.2-3) unstable; urgency=medium * Add a simple autopkgtest, loosely based on the patch provided by diff -Nru ebook-tools-0.2.2/debian/tests/build ebook-tools-0.2.2/debian/tests/build --- ebook-tools-0.2.2/debian/tests/build 2014-07-23 20:37:38.000000000 +0200 +++ ebook-tools-0.2.2/debian/tests/build 2014-07-28 07:23:23.000000000 +0200 @@ -3,5 +3,5 @@ SRCDIR=$(dirname $(realpath $0)) cd $ADTTMP -gcc -Wall -Werror -pedantic -std=c90 -lepub -o test-libepub $SRCDIR/test-libepub.c +gcc -Wall -Werror -pedantic -std=c90 -o test-libepub $SRCDIR/test-libepub.c -lepub ./test-libepub "$SRCDIR/wasteland-20120118.epub"
