On 16/04/14 10:58, Thibaut Paumard wrote: > Control: owner -1 ! > Control: tag -1 + pending > > > Dear Tomasz,
Hi Thibaut, I didn't miss your review - I didn't have time to work on it properly :). > > debian/copyright is incomplete. Use "licensecheck", "grep" and "less" to > find out the copyright and license of each individual file. Here are a > few copyright notices which you did not list in debian/copyright: > > Copyright: " 2003-2014 Gravit Development Team" / 2003-2014 Gerald Kaszuba > Copyright: 2008 Matt Gallagher. All rights reserved > Copyright: 1997, 1998, 1999, 2000, 2001, 2002 Sam Lantinga > Copyright: 2006 Angelo "Encelo" Theodorou > Copyright (C) 1994-2008 Lua.org, PUC-Rio. All rights reserved The new package is uploaded to mentors: http://mentors.debian.net/package/gravit What I did: 1) I did my best to address copyright issues; I think that d/copyright is fine now, but it would great if you could take a look; for the same reason I repack the original tarball (see debian/repack); probably 2 issues remain: - there is Vera.ttf in the tarball; I don't install it, but symlink it from ttf-bitstream-vera; so I don't mention it - there are some custom autconf scripts in 'acinclude'; they are not mentioned in d/copyright because I don't consider them to be a part of the distribution 2) I improved the build process with autoreconf > > Some files are not GPL. For some files it's not even clear that they are > DFSG, please check it and document your findings in debian/copyright. If > in doubt (and if those files are not used in building), repack. > > debian/changelog is too verbose. It should only list "initial upload. > (Closes: ITPbugnr)". 3) I fixed that and added +dfsg to the version number > > The package is not lintian-clean. You need to write a manpage for the > 'gravit' binary. I was not able to find out how to use it as a screen > saver, which is certainly not a good idea given the resources it takes! 4) I've added a simple manpage which I'll try to push upstream > > gravit-data should certainly Recommend gravit, and I believe gravit > should Depend on gravit-data (=${source:Version}) rather than (>= > ${source:Version}). 5) Ok, done. > > Kind regards, Thibaut. > There are smaller problems with upstream, still: 1) autoconf/make/etc. is using deprecated filenames and options which apparently may break in the future 2) the code is licensed under GPL-2 without "or later version" clause; it is a small problem for maintaining debian/control since a few 3rd party fragments are licensed under GPL-2+; but I don't think they are blocking. I'll work with upstream to fix them. Cheers, Tomasz -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
