On Sat, Jul 19, 2014 at 07:35:00PM +0200, Stefano Zacchiroli wrote: > On Fri, Jul 18, 2014 at 07:59:28PM -0700, Vagrant Cascadian wrote: > I've no substantial objections to your patch (only minor nitpicking here > and there, which I could fix myself).
Thanks for taking a look at it. > What I wonder about is what would > be the best Mutt user interface for this feature, and I could use some > real user (= you :-), or Emacs users explaining how they do that in > their world) feedback about that. In particular: As an inexperienced notmuch-emacs user, it seems to only do threads, although the default search returns each thread as a single line: Yest. 19:59 [3/3] Vagrant Cascadian, Debian Bug Tracking System, Stefano Zacchiroli Bug#755246: notmuch-mutt: search that returns whole threads (debbugs debian inbox sent signed to) Selecting that line brings up an indented thread of the messages, which I don't forsee being feasible to emulate in mutt, unless mutt has some tricks I'm unaware of (and surely it might). The other threaded tree view is more like mutt's typical threads: Yest. 19:59 Vagrant Cascadian ┬►Bug#755246: notmuch-mutt: search that returns whole threads (debbugs debian inbox sent signed) Yest. 20:03 Debian Bug Tracking ├─►Bug#755246: Acknowledgement (notmuch-mutt: search that returns whole threads) (debbugs debian inbox to) Today 10:35 Stefano Zacchiroli ╰─►Bug#755246: notmuch-mutt: search that returns whole threads (debbugs debian inbox signed to) Maybe only one of the messages is in your search terms, but it'll display the whole thread. This is basically what my patch emulates, through relying on mutt's normal threading support, and just feeding it all the messages in the thread. > - do you want to have both thread-full and thread-less searches > available from Mutt? > > (my answer here is yes, because I can easily imagine cases in which > doing thread-full searches only will degenerate in bloated answers Yes, I think both are independently useful, largely for the reason you describe. > - would you like to have only one search keybinding + the ability to set > a default about whether THE search is thread-less/full + the ability > to override it at invocation-time? Given that I already need to remap the keybindings a bit (usually running mutt in byobu, which grabs most of the function keys), ideally it could be only one keybinding. It's probably hard to find enough reasonable non-conflicting default keybindings as it is... I would like the ability to set the default via a config file, i.e. full thread search vs. individual message search, but able to override the default when invoking a particular query on an as-needed basis... > (implementing it won't be entirely trivial because Mutt's macro > language is kinda limited in this respect, but I can think about > something) I guess you could abuse the search term query by adding special search terms such as thread:yes or thread:no to override whatever the default setting is. A little ugly, especially if notmuch ever implements a "thread:" query type, but fairly easy to implement. It would be annoying to be asked both the search term itself as on question, followed by a second question asking if you want threaded or unthreaded responses. Figuring out how to avoid that would be nice. live well, vagrant
signature.asc
Description: Digital signature
