On 2014-07-14 14:35:30, Dustin Kirkland wrote: > > As I read CC-BY-3.0 it is enough to mention to license or add a link > > back to > > it. Since this is done in d/copyright, there is no need to patch a copy > > of > > CC-BY-3.0 in. If the FTP masters want a copy of (or a link to) the > > license, > > we would need to repack the orig tarball anyway to include it there. > > Okay. Any changes required by me, then?
I think it's fine as it is. If it's not enough for FTP masters, we'll deal with it once we know what they don't like. > > * I think there is no point in installing readme.txt as it contains no > > additional information. For readme.html to be useful, the image links > > need to > > be patched. After this has been fixed, registering readme.html with > > doc-base > > would be nice. > > Hmm, so I did that, created the patch, and it's over 1000 lines, > touching basically every <img src...> in that file. > > So, instead, I just created a single symlink in debian/links, that > puts the icons dir in the doc location, so that those relative links > work. This is a lot simpler and cleaner, in my opinion, than creating > a thousand line patch against the upstream readme.html. Yes, that's better than patching. :) > As for registering with doc-base, does dh not just handle that for us > already, since readme.html is in debian/docs? Unfortunately no. Listing a file in debian/docs only causes it to get installed in /usr/share/doc/$package. To register documentation with doc-base a debian/$package.doc-base is required. It could look something like this: Document: famfamfam-silk Title: FamFamFam "Silk" icon set Section: Graphics Format: HTML Index: /usr/share/doc/famfamfam-silk/readme.html Files: /usr/share/doc/famfamfam-silk/readme.html > Updated sources at: http://www.dustinkirkland.com/debian/famfamfam-silk Looks good. One last thing: please change Priority to optional since the packages that will depend on it are already optional. Cheers -- Sebastian Ramacher
signature.asc
Description: Digital signature
