tags 339938 + patch
thanks

Daniel Leidert wrote:

> The style guidelines for GNU ChangeLog files state:
> 
> Break long lists of function names by closing continued lines with ')',
> rather than ',', and opening the continuation with '(' as in this
> example:
> 
>     * keyboard.c (menu_bar_items, tool_bar_items)
>     (Fexecute_extended_command): Deal with `keymap' property.
> 
> (http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs)
> 
> The current enscript only highlights the last '(...)' before the ':' but
> not all the other function lists. It would be really nice if you could
> fix this bug.

A fix is attached. It should expect a ':' or a newline after the closing
bracket. For really long lists this should also be done for the last
regex pattern ('Function name descriptions without file names.').

Regards, Daniel
--- /usr/share/enscript/hl/changelog.st.original	2005-02-13 21:00:59.000000000 +0100
+++ /usr/share/enscript/hl/changelog.st	2005-11-25 02:18:59.000000000 +0100
@@ -26,7 +26,7 @@ state changelog extends HighlightEntry
   }
 
   /* File descriptions with function names. */
-  /(^\t\* )([^\(]+)(\()([^\)]+)(\):)/ {
+  /(^\t\* )([^\(]+)(\()([^\)]+)(\)[:\n])/ {
     language_print ($1);
 
     function_name_face (true);
@@ -54,7 +54,7 @@ state changelog extends HighlightEntry
   }
 
   /* Function name descriptions without file names. */
-  /(^\t\()([^\)]+)(\):)/ {
+  /(^\t\()([^\)]+)(\)[:\n])/ {
     language_print ($1);
 
     keyword_face (true);

Reply via email to