Thanks for packaging a GNUstep game. Unfortunately I can't sponsor.
I have a few comments, though.
Riley wrote:
> * License : GPL2
The license is GPL-2+, AFAICS.
> Section : gnustep
A more appropriate section would be "games".
> * Removed broken, unnecessary menu items
This should not be in the changelog.
control:
- Build-Depends:
Remove libbobjc-4.9-dev and libgcc-4.9-dev -- these are fulfilled
by gnustep-make and are volatile, you should not hardcode them.
You may as well remove gnustep-make as libgnustep-base-dev will
always depend on it. You only need a versioned dependency on -make
if you require a particular feature.
Likewise, libgnustep-base-dev is fulfilled by libgnustep-gui-dev.
- Depends:
Remove gnustep-gpbs. The package is gone so your package will not
be installable. GNUstep Backend dependencies are volatile too, and
are added automatically via libgnustep-gui's shlibs. No package
should use them directly, that's asking for trouble and pain
during GNUstep transitions.
rules:
- You can include /usr/share/GNUstep/debian/config.mk instead of
exporting GNUSTEP_* variables.
- Please use $(MAKE) instead of make, this ensures that sub-makes
work properly.
- You use $(optim) but the conditional to define the variable is missing.
- Why override_dh_userlocal with no recipe?
- Just delete GMastermind.desktop -- it is invalid and in a non-standard
location.
- You should move Resources to /usr/share/GNUstep and install a
symlink, then the lintian override can be removed.
- Move the /usr/bin symlink to /usr/games here.
postinst, postrm:
Completely unnecessary (and broken), delete them.
gmastermind.app.6:
Likewise. The manpage should be named after the binary, and you
already have GMastermind.6.
gmastermind.app.menu:
Could be renamed to menu, and would be nice to have a XPM icon for WMs
that support icons in menus. This is easily done with imagemagick, but
there are other ways, of course. You could also include a .desktop file
and install it in /usr/share/applications.
README.Debian:
I think it's redundant and contains no useful/important information
for the user. There's also a thinko (/usr/bin instead of /usr/games).
docs:
Upstream's README is redundant too, no reason to install it
(information already present in the package description and
debian/copyright).
copyright:
The Ustream-Name is GMastermind.
Take a look at (gs)dh_gnustep. It is not very capable for apps,
unfortunately, but will add a gnustep-fhs-layout dependency via
${gnustep:Depends}.
Once your package is in Debian, please file a wishlist bug against
gnustep-games so that we don't forget to add it as a dependency.
You are also welcome to join pkg-gnustep and host your package there,
if you wish so.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
