Hello
Alexey Bestchiokov wrote:
> 1) -m fields. man example :
> ~> flow-export -f3 -mSRCADDR,DSTADDR,DOCTETS -u
> "user:password:host:port:name:table" < flow
> flow-export: Out of order field: DOCTETS
> flow-export: ftxfield_parse(): failed
>
> However, -m0x0000000000003040LL (the same) works ok.
The following should be mentioned in the manpage, and also is an error
in the example.
flow-export expects the arguments to be given in the order they are
specified in the man page, and so correct would be:
-mDOCTETS,SRCADDR,DSTADDR
(just looked through the code to understand this)
>
> 2) postgresql export
> /usr/bin/flow-export -f5 -m0x0000000000003040LL -u
> "user:password:host:5432:name:table" < flow
>
> flow-export: Missing field in dbaseURI, expecting
> user:pwd:host:port:name:table.
> /usr/bin/flow-export: Exported 0 records
>
> fix :
> src/flow-export.c, line 896 should look like this
> if (!db_user || !db_pwd || !db_host || !db_port || !db_name || !db_table) {
>
> (db_port instead of db_tmp, db_tmp declaration at line 869 may be removed.)
>
> Actually, PQsetdbLogin should be replaced with PQconnectdb as
> PQsetdbLogin is deprecated and exists mainly to support legacy applications.
> But this is upstream problem.
>
i will accept this patch
> 3) postgresql export, " quotation for SRCADDR, DSTADDR, NEXTHOP,
> PEER_NEXTHOP, EXADDR, ROUTER_SC
> fields is used so queries with such fileds will fail. its ok for mysql
> but in pgsql " style quotation may be used only for database objects
> and table fields.
>
> fix :
> src/flow-export.c, lines 1204, 1207, 1262, 1280, 1283, 1380, 1383, 1389,
> 1392 should be
> if (quote) fmt_buf[len++] = '\'';
>
Question: why \' and not just ' ?
Radu
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
