Package: calypso
Version: 1.4

Around webdav.py:512 we have:

                self.import_item(new_ics)

but import_item requires two arguments:

    def import_item(self, new_item, path):

An attempt to fix this with

                self.import_item(new_ics, path)

exposes other issues, i.e. the use of path in the final catch handler
here may crash when write_file() throws an exception:

        try:
            path = self.write_file(item)
            self.git_add(path, context=context)
            self.scan_dir(True)
        except OSError, ex:
            self.log.exception("Error writing file")
            raise
        except Exception, ex:
            self.log.exception("Caught Exception")
            self.log.debug("Failed to create %s: %s", path,  ex)
            raise

This was all discovered by an attempt to call

  calypso --import private/rlb foo.vcf

with a foo.vcf containing a single vcard.

Thanks
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to