Bug#753133: postr: flickr API went SSL only today

[Tim Connors]

Package: postr
Version: 0.13-1
Severity: grave
Tags: patch
Justification: renders package unusable

API went SSL only today:
https://www.flickr.com/help/forum/en-us/72157645440333073/

My basic little patch seems to work for the handful of things I've
tried, but I've probably missed something.

Also need to add a dependency on python-openssl.  My patch doesn't do
that since I'm a bit clueless.

-- System Information:
Debian Release: 7.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (5, 'testing'), (2, 
'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13-0.bpo.1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages postr depends on:
ii  chromium [www-browser]                35.0.1916.153-1~deb7u1
ii  google-chrome-unstable [www-browser]  37.0.2054.3-1
ii  iceweasel [www-browser]               24.6.0esr-1~deb7u1
ii  konqueror [www-browser]               4:4.8.4-2
ii  links [www-browser]                   2.7-1+deb7u1
ii  lynx-cur [www-browser]                2.8.8dev.12-2
ii  python                                2.7.6-2
ii  python-bsddb3                         6.0.1-1+b1
ii  python-gconf                          2.28.1+dfsg-1
ii  python-glade2                         2.24.0-3+b1
ii  python-gnome2                         2.28.1+dfsg-1
ii  python-gtk2                           2.24.0-3+b1
ii  python-nautilus                       1.1-3
ii  python-twisted-web                    12.0.0-1
ii  w3m [www-browser]                     0.5.3-8

postr recommends no packages.

postr suggests no packages.

-- no debconf information

Description: Attempt to move to https API: https://www.flickr.com/help/forum/en-us/72157645440333073/
 
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:

Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>

--- postr-0.13.orig/src/flickrest.py	2014-06-29 20:52:37.000000000 +1000
+++ postr-0.13/src/flickrest.py	2014-06-29 23:26:15.227424687 +1000
@@ -47,7 +47,7 @@
  SIZE_LARGE) = range (0, 5)
 
 class Flickr:
-    endpoint = "http://api.flickr.com/services/rest/?";
+    endpoint = "https://api.flickr.com/services/rest/?";
     
     def __init__(self, api_key, secret, perms="read"):
         self.__methods = {}
@@ -208,7 +208,7 @@
             }
 
         self.logger.info("Calling upload")
-        return client.upload("http://api.flickr.com/services/upload/";,
+        return client.upload("https://api.flickr.com/services/upload/";,
                              proxy=self.proxy, method="POST",
                              headers=headers, postdata=form,
                              progress_tracker=progress_tracker).addCallback(self.__cb, "upload")
@@ -245,7 +245,7 @@
             keys = { 'perms': self.perms,
                      'frob': frob }
             self.__sign(keys)
-            url = "http://flickr.com/services/auth/?api_key=%(api_key)s&perms=%(perms)s&frob=%(frob)s&api_sig=%(api_sig)s" % keys
+            url = "https://flickr.com/services/auth/?api_key=%(api_key)s&perms=%(perms)s&frob=%(frob)s&api_sig=%(api_sig)s" % keys
             return {'url': url, 'frob': frob}
         return self.auth_getFrob().addCallback(gotFrob)
 
@@ -299,4 +299,4 @@
         elif size == SIZE_LARGE:
             suffix = "_b"
 
-        return "http://static.flickr.com/%s/%s_%s%s.jpg"; % (photo.get("server"), photo.get("id"), photo.get("secret"), suffix)
+        return "https://static.flickr.com/%s/%s_%s%s.jpg"; % (photo.get("server"), photo.get("id"), photo.get("secret"), suffix)
--- postr-0.13.orig/src/postr.py	2014-06-29 20:52:37.000000000 +1000
+++ postr-0.13/src/postr.py	2014-06-29 23:26:22.987484867 +1000
@@ -223,11 +223,11 @@
                 user = client.get_string("/system/http_proxy/authentication_user")
                 password = client.get_string("/system/http_proxy/authentication_password")
                 if user and user != "":
-                    url = "http://%s:%s@%s:%d"; % (user, password, host, port)
+                    url = "https://%s:%s@%s:%d"; % (user, password, host, port)
                 else:
-                    url = "http://%s:%d"; % (host, port)
+                    url = "https://%s:%d"; % (host, port)
             else:
-                url = "http://%s:%d"; % (host, port)
+                url = "https://%s:%d"; % (host, port)
 
             self.flickr.set_proxy(url)
         else:
--- postr-0.13.orig/src/util.py	2014-05-24 05:36:21.000000000 +1000
+++ postr-0.13/src/util.py	2014-06-29 23:26:29.583536019 +1000
@@ -98,9 +98,9 @@
         return load_thumb(page, size)
     
     if int(data.get("iconfarm")) > 0:
-        url = "http://farm%s.static.flickr.com/%s/buddyicons/%s.jpg"; % (data.get("iconfarm"), data.get("iconserver"), data.get("nsid"))
+        url = "https://farm%s.static.flickr.com/%s/buddyicons/%s.jpg"; % (data.get("iconfarm"), data.get("iconserver"), data.get("nsid"))
     else:
-        url = "http://www.flickr.com/images/buddyicon.jpg";
+        url = "https://www.flickr.com/images/buddyicon.jpg";
 
     if __buddy_cache.has_key(url):
         from twisted.internet import defer