Package: xtitle
Version: 1.0.2-6
Severity: normal

Hi,

I'm looking at xtitle, and I see some code that doesn't make sense:

  [ ! "$arget" ] && target=$default

(note the mispelling of the $target variable in the condition.

And:

  case "$target" in
  *i*|*t*) something="something" ;;
  esac

without $something being used later. Basically this code is no-op.

Upon further investigation, these are not an upstream problems, but
rather were introduced in 40-help.patch, but that patch seems badly
named - it seems rather to rewrite half of the script.

I just want to flag that that patch probably needs some attention.
Whether the patch itself is needed at all, is another discussion…

regards,
iustin

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.14.4-ruru0 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages xtitle depends on:
ii  kterm [x-terminal-emulator]         6.2.0-46.1
ii  rxvt-unicode [x-terminal-emulator]  9.20-1
ii  xterm [x-terminal-emulator]         304-1

xtitle recommends no packages.

xtitle suggests no packages.

-- no debconf information

Attachment: signature.asc
Description: Digital signature

Reply via email to