Package: tinyca
Version: 0.7.5-5
Severity: important
Hi Christoph,
I'm not sure exactly what changed to do this, but running tinyca on any
release later than squeeze renders the toolbar buttons without any label
text. Which makes it almost impossible to use, given that several of the
icons are identical :)
Since nothing in tinyca itself has changed that should in any way effect
this, I assume that it's gtk which changed the default style for toolbars.
It could be some change to the theme settings, but I couldn't find any
way to change those which would fix this.
Either way, there really only is one style which works for this app in
its present form, so it doesn't make any sense for it to be at the whim
of a global theme in any case. And since that turned out to be fairly
easy to fix, here's a patch that does just that.
(or rather two patches, since there's some dead code just above where
this needed to be fixed that I've attached a patch for too)
Thanks for maintaining this!
Cheers,
Ron
>From 751276835e0f808edfcb1e3d54ed4cbb86a7d1ae Mon Sep 17 00:00:00 2001
From: Ron <r...@debian.org>
Date: Thu, 19 Jun 2014 03:45:43 +0930
Subject: [PATCH 1/2] Don't create a Toolbar that is never used
This appears to be a 'typo' that was introduced in the Gtk2 rewrite
between version 0.6.8 and 0.7.0, which should be harmless, but is
quite useless, so get rid of it while we're in here changing things.
---
lib/GUI.pm | 4 ----
1 file changed, 4 deletions(-)
diff --git a/lib/GUI.pm b/lib/GUI.pm
index bd98543..25c1363 100644
--- a/lib/GUI.pm
+++ b/lib/GUI.pm
@@ -439,10 +439,6 @@ sub create_toolbar {
$c->destroy();
}
} else {
- $self->{'toolbar'} = Gtk2::Toolbar->new();
- $self->{'toolbar'}->set_orientation('horizontal');
- $self->{'toolbar'}->set_icon_size('small-toolbar');
-
## Buttons for all toolbars
$self->{'toolbar'} = Gtk2::Toolbar->new();
$self->{'toolbar'}->set_orientation('horizontal');
--
2.0.0.rc2
>From 20d6a211e7ea13478a83f9a664b34802766b874d Mon Sep 17 00:00:00 2001
From: Ron <r...@debian.org>
Date: Thu, 19 Jun 2014 03:53:14 +0930
Subject: [PATCH 2/2] Put the text labels back on the ToolButtons again
Somewhere between squeeze and wheezy, something changed the default style
for a ToolButton to no longer show its label, only its icon. For this
application that's a bit of a problem since several of the icons on the
Toolbar are identical, and it has no tooltips, so it's impossible to know
what each of them actually does, even if you've memorised the icons for
whatever theme of the day selects them.
So explicitly tell it to show both. This was explicitly indicated before
the Gtk2 rewrite, but got dropped since Gtk2::Toolbar->new changed. We
could fairly easily add tooltips too, but they aren't really needed with
the text labels, and without the text labels you'd need to wave the mouse
pointer around to figure out what all the options are, so this seems both
the best and easiest fix.
---
lib/GUI.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/GUI.pm b/lib/GUI.pm
index 25c1363..1ae6b81 100644
--- a/lib/GUI.pm
+++ b/lib/GUI.pm
@@ -442,6 +442,7 @@ sub create_toolbar {
## Buttons for all toolbars
$self->{'toolbar'} = Gtk2::Toolbar->new();
$self->{'toolbar'}->set_orientation('horizontal');
+ $self->{'toolbar'}->set_style('both');
$button = Gtk2::ToolButton->new_from_stock('gtk-quit');
$self->{'toolbar'}->insert($button, -1);
--
2.0.0.rc2
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
