Dear patch submitter,
I am not a pcre3 maintainer, but I'd like to comment on your patch.
On Thu, Jun 12, 2014 at 02:00:26PM +0200, Erwan Prioul wrote:
> For the ppc64el architecture in Ubuntu, since this package uses libtool, a
> full autoreconf is necessary. This is because we need new libtool macros for
> ppc64el.
>
> In Ubuntu, the attached patch was applied to achieve the following:
>
> * Build using dh-autoreconf for new port support.
> * Enable parallel builds.
parallel building is not necessary for making ppc64el work.
> * Disable JIT on ppc64el, needs explicit porting to ELFv2.
The patch also changes the dh_makeshlibs invocations without explaining
why.
In general the patch has several weaknesses:
* It conflates multiple issues into a single patch. Consider splitting.
* It fails to explain those changes in a changelog entry.
* It patches files outside the debian directory without adding a patch
to debian/patches nor including suitable DEP-3 patch tags.
> Thanks for considering the patch.
Please consider reworking the patch to address some of the above.
In the mean time I am going to use a different patch for rebootstrap[1],
that just addresses the dh-autoreconf aspect and makes the build
generally work (without implying that the results would be usable).
Helmut
[1] https://wiki.debian.org/HelmutGrohne/rebootstrap
diff -Nru pcre3-8.31/debian/changelog pcre3-8.31/debian/changelog
--- pcre3-8.31/debian/changelog
+++ pcre3-8.31/debian/changelog
@@ -1,3 +1,10 @@
+pcre3 (1:8.31-5.1) UNRELEASED; urgency=low
+
+ * Non-maintainer upload.
+ * Use dh-autoreconf for ppc64el. (Closes: #751390)
+
+ -- Helmut Grohne <hel...@subdivi.de> Mon, 16 Jun 2014 07:08:47 +0200
+
pcre3 (1:8.31-5) unstable; urgency=medium
* Previous attempt at detecting JIT support didn't work when cross
diff -Nru pcre3-8.31/debian/control pcre3-8.31/debian/control
--- pcre3-8.31/debian/control
+++ pcre3-8.31/debian/control
@@ -3,7 +3,7 @@
Priority: optional
Maintainer: Mark Baker <m...@mnb.org.uk>
Standards-Version: 3.9.3
-Build-Depends: debhelper (>= 5.0.22), dpkg-dev (>= 1.16.0)
+Build-Depends: debhelper (>= 5.0.22), dpkg-dev (>= 1.16.0), dh-autoreconf
Package: libpcre3
Section: libs
diff -Nru pcre3-8.31/debian/rules pcre3-8.31/debian/rules
--- pcre3-8.31/debian/rules
+++ pcre3-8.31/debian/rules
@@ -27,9 +27,10 @@
INSTALL_PROGRAM += -s
endif
-config.status: configure
+configure-stamp:
dh_testdir
# Add here commands to configure the package.
+ dh_autoreconf
CC_FOR_BUILD=cc CFLAGS="$(CFLAGS)" ./configure \
--host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) \
--prefix=/usr --mandir=\$${prefix}/share/man \
@@ -38,11 +39,12 @@
--enable-utf8 --enable-unicode-properties \
--disable-silent-rules \
$(shell . debian/jit-test)
+ touch configure-stamp
build: build-arch build-indep
build-arch: build-stamp
build-indep: build-stamp
-build-stamp: config.status
+build-stamp: configure-stamp
dh_testdir
# Add here commands to compile the package.
@@ -53,10 +55,10 @@
touch build-stamp
-clean: config.status
+clean: configure-stamp
dh_testdir
dh_testroot
- rm -f build-stamp
+ rm -f build-stamp configure-stamp
# Add here commands to clean up after the build process.
[ ! -f Makefile ] || $(MAKE) distclean
### -test -r /usr/share/misc/config.sub && \
@@ -64,6 +66,7 @@
### -test -r /usr/share/misc/config.guess && \
### cp -f /usr/share/misc/config.guess config.guess
rm -f dftables testsavedregex
+ dh_autoreconf_clean
dh_clean
install: build
