Package: netselect-apt
Version: 0.3.ds1-25
Severity: critical
Tags: patch
Justification: breaks the whole system



-- System Information:
Debian Release: 7.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages netselect-apt depends on:
ii  netselect  0.3.ds1-25
ii  wget       1.13.4-3+deb7u1

Versions of packages netselect-apt recommends:
ii  curl  7.26.0-1+wheezy9

Versions of packages netselect-apt suggests:
ii  dpkg-dev  1.16.14

-- no debconf information

When the script enters final phase for an unknown reason it tries a mirror host 
-
Apparently this cause curl to interpret the hostname as an option and return 
immediatly.
# Debian packages for stable
deb - stable main contrib non-free
# Uncomment the deb-src line if you want 'apt-get source'
# to work with most packages.
deb-src - stable main contrib non-free


To address the issue I have add 2 tests and corrected one that
I think was wrong inside the test_host function:
--- x   2014-06-08 22:50:28.628202003 +0200
+++ /usr/bin/netselect-apt      2014-06-08 22:50:41.068091221 +0200
@@ -111,7 +111,9 @@
 {
     local host="$1"
     local rv=0
-    [ ! -x /usr/bin/curl  ] && return 0
+    [ ! -x /usr/bin/curl  ] && return 255
+    [[ "@${host:0:1}" == "@-" ]] && return 255
+    [[ -z "${host}" ]] && return 255
 
     # First test: does it actually serve anything?
     curl -m 2 -q -s "$host"  >/dev/null 2>&1


The return -1 on the calling function validate_host seems not good either, 
generates return: -1: invalid option
Probably need to be changed to return 255


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to