On Tue, May 27, 2014 at 11:43:38PM +0800, Bai Shi wrote:
> Do you mind to advice on the below statement. Does it wait for stat
> fail in purpose?
> 
> if (stat(DEFAULT_PRELOAD, &ts) < 0 || S_ISREG(ts.st_mode))
It does look a bit odd doesn't it?
If stat fails OR (stat doesn't fail AND its a regular file)
then load the file.

I think it should be
if stat works AND its a regular file  THEN load it, but ill check the
logic, there was some odd return value behaviour; perhaps a mandatory
presence of the config file.

 - Craig
> 

-- 
Craig Small (@smallsees)   http://enc.com.au/       csmall at : enc.com.au
Debian GNU/Linux           http://www.debian.org/   csmall at : debian.org
GPG fingerprint:        5D2F B320 B825 D939 04D2  0519 3938 F96B DF50 FEA5


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to